session->connect_utime doesn't appear to be populated

[Ronald Bradford]

Query Logging presents two values.

t_mark,
 (t_mark - session->connect_utime),

These are always equal, Mark Atwood thinks session->connect_utime may not be being populated. My only evidence is output, not code.

1248216631322097,1,5,"test","select * from numbers limit 100","Query",1248216631322097,281,217,100,1002,0
1248216642763174,1,6,"test","select * from numbers limit 101","Query",1248216642763174,268,215,101,1012,0

[Jay Pipes (jaypipes)]

Seems like connect_utime is indeed not being set...check out the difference between MySQL 5.4 and Drizzle:

jpipes@serialcoder:~/repos/drizzle/bugs$ ack-grep connect_utime
plugin/logging_query/logging_query.cc
258: /* TODO, looks like connect_utime isnt being set in the session
305: (t_mark - session->connect_utime),

plugin/logging_gearman/logging_gearman.cc
228: /* TODO, looks like connect_utime isnt being set in the session
266: (t_mark - session->connect_utime),

plugin/logging_syslog/logging_syslog.cc
126: /* TODO, looks like connect_utime isnt being set in the session
164: (unsigned long long) (t_mark - session->connect_utime),

drizzled/session.h
555: uint64_t connect_utime;

jpipes@serialcoder:~/repos/mysql-server/5.4/trunk$ ack-grep connect_utime
sql/sql_connect.cc
1079: thd->connect_utime);

sql/sql_class.h
1345: ulonglong connect_utime, thr_create_utime; // track down slow pthread_create

sql/mysqld.cc
4859: thd->connect_utime= thd->start_utime= my_micro_time();

I will go ahead and fix this in my bugs branch...

[Jay Pipes (jaypipes)]

Fix committed in lp:~jaypipes/drizzle/bugs