Rename DrGeoCanvas

Bug #1798944 reported by hilaire
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Dr. Geo
Fix Released
Wishlist
Hannes Hirzel

Bug Description

Rename DrGeoCanvas class as DrGeoSketch

It is more meaningful.

Related branches

Revision history for this message
Hannes Hirzel (hannes-hirzel) wrote : Re: [Bug 1798944] [NEW] Rename DrGeoCanvas

As written in the other comment. I now think rather than renaming a
comprehensive update of the class comment will do a better job.

On 10/20/18, hilaire <email address hidden> wrote:
> Public bug reported:
>
> Rename DrGeoCanvas class as DrGeoSketch
>
> It is more meaningful.
>
> ** Affects: drgeo
> Importance: Wishlist
> Assignee: Hannes Hirzel (hannes-hirzel)
> Status: New
>
>
> ** Tags: smalltalk-sketch
>
> --
> You received this bug notification because you are a member of DrGeo
> developers, which is subscribed to Dr. Geo II.
> Matching subscriptions: Dr. Geo bug report
> https://bugs.launchpad.net/bugs/1798944
>
> Title:
> Rename DrGeoCanvas
>
> Status in Dr. Geo II:
> New
>
> Bug description:
> Rename DrGeoCanvas class as DrGeoSketch
>
> It is more meaningful.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/drgeo/+bug/1798944/+subscriptions
>

Revision history for this message
Hannes Hirzel (hannes-hirzel) wrote :

People coming from a background like this

https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Drawing_shapes

will not have a big problem understanding the conceopt of DrGeoCanvas.

A DrGeoCanvas object as such is not a canvas but it offers an API with
commands to create objects on the canvas and holds a reference to a
canvas object, thus representing it.

On 10/20/18, H. Hirzel <email address hidden> wrote:
> As written in the other comment. I now think rather than renaming a
> comprehensive update of the class comment will do a better job.
>
> On 10/20/18, hilaire <email address hidden> wrote:
>> Public bug reported:
>>
>> Rename DrGeoCanvas class as DrGeoSketch
>>
>> It is more meaningful.
>>
>> ** Affects: drgeo
>> Importance: Wishlist
>> Assignee: Hannes Hirzel (hannes-hirzel)
>> Status: New
>>
>>
>> ** Tags: smalltalk-sketch
>>
>> --
>> You received this bug notification because you are a member of DrGeo
>> developers, which is subscribed to Dr. Geo II.
>> Matching subscriptions: Dr. Geo bug report
>> https://bugs.launchpad.net/bugs/1798944
>>
>> Title:
>> Rename DrGeoCanvas
>>
>> Status in Dr. Geo II:
>> New
>>
>> Bug description:
>> Rename DrGeoCanvas class as DrGeoSketch
>>
>> It is more meaningful.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/drgeo/+bug/1798944/+subscriptions
>>
>

Revision history for this message
Hannes Hirzel (hannes-hirzel) wrote :

The class comment could include the summary of a subset of command
with which you can do a lot.

http://forum.drgeo.eu/DrGeoII-DSL-for-Euclid-sketches-Summary-October-2018-td4025471.html

Having had this class comment and the instruction to start reading it
DrGeoCanvas would have helped me a lot two months ago.

On 10/20/18, H. Hirzel <email address hidden> wrote:
> People coming from a background like this
>
> https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Drawing_shapes
>
> will not have a big problem understanding the conceopt of DrGeoCanvas.
>
> A DrGeoCanvas object as such is not a canvas but it offers an API with
> commands to create objects on the canvas and holds a reference to a
> canvas object, thus representing it.
>
> On 10/20/18, H. Hirzel <email address hidden> wrote:
>> As written in the other comment. I now think rather than renaming a
>> comprehensive update of the class comment will do a better job.
>>
>> On 10/20/18, hilaire <email address hidden> wrote:
>>> Public bug reported:
>>>
>>> Rename DrGeoCanvas class as DrGeoSketch
>>>
>>> It is more meaningful.
>>>
>>> ** Affects: drgeo
>>> Importance: Wishlist
>>> Assignee: Hannes Hirzel (hannes-hirzel)
>>> Status: New
>>>
>>>
>>> ** Tags: smalltalk-sketch
>>>
>>> --
>>> You received this bug notification because you are a member of DrGeo
>>> developers, which is subscribed to Dr. Geo II.
>>> Matching subscriptions: Dr. Geo bug report
>>> https://bugs.launchpad.net/bugs/1798944
>>>
>>> Title:
>>> Rename DrGeoCanvas
>>>
>>> Status in Dr. Geo II:
>>> New
>>>
>>> Bug description:
>>> Rename DrGeoCanvas class as DrGeoSketch
>>>
>>> It is more meaningful.
>>>
>>> To manage notifications about this bug go to:
>>> https://bugs.launchpad.net/drgeo/+bug/1798944/+subscriptions
>>>
>>
>

Revision history for this message
Hannes Hirzel (hannes-hirzel) wrote :

Also see the introduction of http://fabricjs.com/

"Fabric provides interactive object model on top of canvas element
Fabric also has SVG-to-canvas (and canvas-to-SVG) parser"

Example from
http://fabricjs.com/fabric-intro-part-1
/ create a wrapper around native canvas element (with id="c")
var canvas = new fabric.Canvas('c');

// create a rectangle object
var rect = new fabric.Rect({
  left: 100,
  top: 100,
  fill: 'red',
  width: 20,
  height: 20
});

// "add" rectangle onto canvas
canvas.add(rect);

Summary: Keep the name DrGeoCanvas, but include examples how to deal
with DrGeoCanvas and refer to them from the DrGeoCanvas class comment.

Also we need to add some of the examples developed recently to the
documentation.

On 10/20/18, H. Hirzel <email address hidden> wrote:
> The class comment could include the summary of a subset of command
> with which you can do a lot.
>
> http://forum.drgeo.eu/DrGeoII-DSL-for-Euclid-sketches-Summary-October-2018-td4025471.html
>
> Having had this class comment and the instruction to start reading it
> DrGeoCanvas would have helped me a lot two months ago.
>
>
>
> On 10/20/18, H. Hirzel <email address hidden> wrote:
>> People coming from a background like this
>>
>> https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Drawing_shapes
>>
>> will not have a big problem understanding the conceopt of DrGeoCanvas.
>>
>> A DrGeoCanvas object as such is not a canvas but it offers an API with
>> commands to create objects on the canvas and holds a reference to a
>> canvas object, thus representing it.
>>
>> On 10/20/18, H. Hirzel <email address hidden> wrote:
>>> As written in the other comment. I now think rather than renaming a
>>> comprehensive update of the class comment will do a better job.
>>>
>>> On 10/20/18, hilaire <email address hidden> wrote:
>>>> Public bug reported:
>>>>
>>>> Rename DrGeoCanvas class as DrGeoSketch
>>>>
>>>> It is more meaningful.
>>>>
>>>> ** Affects: drgeo
>>>> Importance: Wishlist
>>>> Assignee: Hannes Hirzel (hannes-hirzel)
>>>> Status: New
>>>>
>>>>
>>>> ** Tags: smalltalk-sketch
>>>>
>>>> --
>>>> You received this bug notification because you are a member of DrGeo
>>>> developers, which is subscribed to Dr. Geo II.
>>>> Matching subscriptions: Dr. Geo bug report
>>>> https://bugs.launchpad.net/bugs/1798944
>>>>
>>>> Title:
>>>> Rename DrGeoCanvas
>>>>
>>>> Status in Dr. Geo II:
>>>> New
>>>>
>>>> Bug description:
>>>> Rename DrGeoCanvas class as DrGeoSketch
>>>>
>>>> It is more meaningful.
>>>>
>>>> To manage notifications about this bug go to:
>>>> https://bugs.launchpad.net/drgeo/+bug/1798944/+subscriptions
>>>>
>>>
>>
>

Changed in drgeo:
status: New → Fix Committed
Changed in drgeo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.