Register metadata is lost after portsec application

Bug #1815416 reported by Omer Anson on 2019-02-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DragonFlow
Undecided
Unassigned

Bug Description

Register information (the metadata in reg6, and metadata) is lost after the postsec application tables. This happens if the datapath code allocates different registers for the source port ID and network ID (which can happen).

This happens because the classifier application jumps directly into the portsec app tables, rather than going through the normal process where the datapath code backs up and restores the registers.

Omer Anson (omer-anson) on 2019-02-11
summary: - Register data is lost after portsec application
+ Register metadata is lost after portsec application

Reviewed: https://review.openstack.org/636042
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=8976a2cf9e5687ed21f4e1542bfc28d9d57fec58
Submitter: Zuul
Branch: master

commit 8976a2cf9e5687ed21f4e1542bfc28d9d57fec58
Author: Omer Anson <email address hidden>
Date: Sun Feb 10 12:12:35 2019 +0200

    Add exitpoint for legacy classifier app

    Classifier app currently sends the packet directly to portsec
    app. This is Bad. As described in the bug, metadata stored in
    registers can be lost.

    This change adds a classifier exitpoint table, and classifier
    app sends the packets there. The datapath wiring then sends
    the packet to the portsec app (if so configured).

    This is important, since sometimes the datapath code allocates different
    registers to the same metadata accross different applications, and registers
    are moved. Skipping this behaviour causes errors.

    Closes-Bug: #1815416
    Change-Id: I38f14e8faa45e4ef3740bdbee78bd493f6d602ab

Changed in dragonflow:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers