flake8 check in dragonflow is out of date

Bug #1663864 reported by Hong Hui Xiao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DragonFlow
Fix Released
Medium
Hong Hui Xiao

Bug Description

The config for flake8 in dragonflow is out of date now, this bug is used to track the work of change the config of flake8 and related code change in dragonflow.

Hong Hui Xiao (xiaohhui)
Changed in dragonflow:
assignee: nobody → Hong Hui Xiao (xiaohhui)
Changed in dragonflow:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/432714

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (master)

Reviewed: https://review.openstack.org/432520
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=f05852e71073f0b03ab96f8ebb22ab374b3e3f51
Submitter: Jenkins
Branch: master

commit f05852e71073f0b03ab96f8ebb22ab374b3e3f51
Author: Hong Hui Xiao <email address hidden>
Date: Sat Feb 11 11:18:10 2017 +0800

    Add H233 to pep8 check

    H233 will report error when print is used as operator.
    print operator has been removed in py3. We should add H233 check
    as py3 is in the support list. This problem was first found at [1]
    We can launch the check for future code.

    [1] https://review.openstack.org/#/c/396915/

    Change-Id: I4fef99c24941f048fd61a808e03869bacd30c001
    Co-Authored-By: Wang Jian <email address hidden>
    Partial-Bug: #1663864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/432900

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (master)

Reviewed: https://review.openstack.org/432524
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=bc5df105eabfaf4e3de409a6853173a47bd3878f
Submitter: Jenkins
Branch: master

commit bc5df105eabfaf4e3de409a6853173a47bd3878f
Author: Hong Hui Xiao <email address hidden>
Date: Sat Feb 11 11:36:24 2017 +0800

    Remove N342 from pep8 ignore list

    Current N342 is the nova check for central conf files.
    [N342] Config options should be in the central location nova/conf/
    We can just remove it from the ignore list. Hopefully, future rule
    will be added in neutron-lib for such check in networking project.

    Change-Id: Ib4d3eadeb100ea26f7ccfeaca14a219c29e43c2e
    Partial-Bug: #1663864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/432525
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=17496f11ad5fabf0f91f6475efe62ff41df543ad
Submitter: Jenkins
Branch: master

commit 17496f11ad5fabf0f91f6475efe62ff41df543ad
Author: Hong Hui Xiao <email address hidden>
Date: Sat Feb 11 12:00:48 2017 +0800

    Add H301 check to pep8

    [H301] Do not import more than one module per line (*)
    is now in the ignore list of dragonflow pep8 check. However,
    [1] and some following work has cleaned the dragonflow import code.
    So, we can add the check in pep8 for future code.

    [1] https://review.openstack.org/#/c/360956/

    Change-Id: Ib583f8be57cc1976d868433613f70378d8809f0d
    Partial-Bug: #1663864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/432559
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=e4e0a58e3310c23d630267806ade45650c2e9c36
Submitter: Jenkins
Branch: master

commit e4e0a58e3310c23d630267806ade45650c2e9c36
Author: Hong Hui Xiao <email address hidden>
Date: Sat Feb 11 14:29:17 2017 +0800

    Add H904 to pep8 check

    H904: Delay string interpolations at logging calls, which is the
    former N342, prevents format string when add log. Enabling it can
    uniform the way we do log.

    Change-Id: I4d16a7db530d9fa5a641140e03680307f878f0bb
    Partial-Bug: #1663864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/432963

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (master)

Reviewed: https://review.openstack.org/432714
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=e6db08a184adc0bdac46b01bf14a18b6dc55ad7a
Submitter: Jenkins
Branch: master

commit e6db08a184adc0bdac46b01bf14a18b6dc55ad7a
Author: Hong Hui Xiao <email address hidden>
Date: Sun Feb 12 08:59:00 2017 +0800

    Add E265 to the pep8 check list

    E265 block comment should start with '#'

    Change-Id: Ia1712504559ab8d43769d07724937ce65100dc07
    Partial-Bug: #1663864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/432900
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=95de68ea33416e4f178c5b0a1ff0a836f922f442
Submitter: Jenkins
Branch: master

commit 95de68ea33416e4f178c5b0a1ff0a836f922f442
Author: Hong Hui Xiao <email address hidden>
Date: Mon Feb 13 15:14:44 2017 +0800

    Add E128 to pep8 check list

    Unlike E126, which is controversial, E128 is a check should be applied
    to code.

    E128 continuation line under-indented for visual indent

    Change-Id: Idc67968dcc424e8eef252fff1704c96d32fe452a
    Partial-Bug: #1663864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/433647

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/433654

Li Ma (nick-ma-z)
Changed in dragonflow:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (stable/ocata)

Reviewed: https://review.openstack.org/432963
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=63afd0807b8897ffc4bc053da0cfd8a94fade9d5
Submitter: Jenkins
Branch: stable/ocata

commit 63afd0807b8897ffc4bc053da0cfd8a94fade9d5
Author: Hong Hui Xiao <email address hidden>
Date: Sat Feb 11 11:18:10 2017 +0800

    Add H233 to pep8 check

    H233 will report error when print is used as operator.
    print operator has been removed in py3. We should add H233 check
    as py3 is in the support list. This problem was first found at [1]
    We can launch the check for future code.

    [1] https://review.openstack.org/#/c/396915/

    Change-Id: I4fef99c24941f048fd61a808e03869bacd30c001
    Co-Authored-By: Wang Jian <email address hidden>
    Partial-Bug: #1663864
    (cherry picked from commit f05852e71073f0b03ab96f8ebb22ab374b3e3f51)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/434246

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (master)

Reviewed: https://review.openstack.org/433647
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=862d48df34ae909de90db02c84f5ae4d87286072
Submitter: Jenkins
Branch: master

commit 862d48df34ae909de90db02c84f5ae4d87286072
Author: Hong Hui Xiao <email address hidden>
Date: Tue Feb 14 21:32:22 2017 +0800

    Add E129 to pep8 check list

    E129: visually indented line with same indent as next logical line

    Change-Id: I5460e5dfa87084c1bd0b72d077e7402fcbb2b7d7
    Partial-Bug: #1663864

Changed in dragonflow:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/433654
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=1dabe808375c845923684ae8767c36057fc69b9e
Submitter: Jenkins
Branch: master

commit 1dabe808375c845923684ae8767c36057fc69b9e
Author: Hong Hui Xiao <email address hidden>
Date: Tue Feb 14 21:45:34 2017 +0800

    Clean the exclude list of flake8

    The exclude list of flake8 is out of date. Update it with latest
    project structure.

    Change-Id: I74bbb234843226a75be81f2662fa6d983644b0f4
    Closes-Bug: #1663864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (stable/ocata)

Reviewed: https://review.openstack.org/434246
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=7cc8a6c30f40e8a0b65a4633f9219a0050bf3dbf
Submitter: Jenkins
Branch: stable/ocata

commit 7cc8a6c30f40e8a0b65a4633f9219a0050bf3dbf
Author: Hong Hui Xiao <email address hidden>
Date: Sat Feb 11 11:36:24 2017 +0800

    Remove N342 from pep8 ignore list

    Current N342 is the nova check for central conf files.
    [N342] Config options should be in the central location nova/conf/
    We can just remove it from the ignore list. Hopefully, future rule
    will be added in neutron-lib for such check in networking project.

    Change-Id: Ib4d3eadeb100ea26f7ccfeaca14a219c29e43c2e
    Partial-Bug: #1663864
    (cherry picked from commit bc5df105eabfaf4e3de409a6853173a47bd3878f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/434574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (stable/ocata)

Reviewed: https://review.openstack.org/434574
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=7f1ed6a71bf3bb3c1faf22bbedbe412d8334ad71
Submitter: Jenkins
Branch: stable/ocata

commit 7f1ed6a71bf3bb3c1faf22bbedbe412d8334ad71
Author: Hong Hui Xiao <email address hidden>
Date: Sat Feb 11 12:00:48 2017 +0800

    Add H301 check to pep8

    [H301] Do not import more than one module per line (*)
    is now in the ignore list of dragonflow pep8 check. However,
    [1] and some following work has cleaned the dragonflow import code.
    So, we can add the check in pep8 for future code.

    [1] https://review.openstack.org/#/c/360956/

    Change-Id: Ib583f8be57cc1976d868433613f70378d8809f0d
    Partial-Bug: #1663864
    (cherry picked from commit 17496f11ad5fabf0f91f6475efe62ff41df543ad)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/435989

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (stable/ocata)

Reviewed: https://review.openstack.org/435989
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=3c2df104753316e37b3cd14e912f557b2de07692
Submitter: Jenkins
Branch: stable/ocata

commit 3c2df104753316e37b3cd14e912f557b2de07692
Author: Hong Hui Xiao <email address hidden>
Date: Sat Feb 11 14:29:17 2017 +0800

    Add H904 to pep8 check

    H904: Delay string interpolations at logging calls, which is the
    former N342, prevents format string when add log. Enabling it can
    uniform the way we do log.

    Change-Id: I4d16a7db530d9fa5a641140e03680307f878f0bb
    Partial-Bug: #1663864
    (cherry picked from commit e4e0a58e3310c23d630267806ade45650c2e9c36)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/437205

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (stable/ocata)

Reviewed: https://review.openstack.org/437205
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=473d6a30bfda93876de1fc22d288c33c9bacbe84
Submitter: Jenkins
Branch: stable/ocata

commit 473d6a30bfda93876de1fc22d288c33c9bacbe84
Author: Hong Hui Xiao <email address hidden>
Date: Sun Feb 12 08:59:00 2017 +0800

    Add E265 to the pep8 check list

    E265 block comment should start with '#'

    Change-Id: Ia1712504559ab8d43769d07724937ce65100dc07
    Partial-Bug: #1663864
    (cherry picked from commit e6db08a184adc0bdac46b01bf14a18b6dc55ad7a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/437860

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/437861

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/437862

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (stable/ocata)

Reviewed: https://review.openstack.org/437860
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=5b2f6caa559945257af5d99e45ee68e38e7b445e
Submitter: Jenkins
Branch: stable/ocata

commit 5b2f6caa559945257af5d99e45ee68e38e7b445e
Author: Hong Hui Xiao <email address hidden>
Date: Mon Feb 13 15:14:44 2017 +0800

    Add E128 to pep8 check list

    Unlike E126, which is controversial, E128 is a check should be applied
    to code.

    E128 continuation line under-indented for visual indent

    Change-Id: Idc67968dcc424e8eef252fff1704c96d32fe452a
    Partial-Bug: #1663864
    (cherry picked from commit 95de68ea33416e4f178c5b0a1ff0a836f922f442)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/437861
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=b313c5e5319c6c7bbadbb5c0e5ec84c2a0717a3f
Submitter: Jenkins
Branch: stable/ocata

commit b313c5e5319c6c7bbadbb5c0e5ec84c2a0717a3f
Author: Hong Hui Xiao <email address hidden>
Date: Tue Feb 14 21:32:22 2017 +0800

    Add E129 to pep8 check list

    E129: visually indented line with same indent as next logical line

    Change-Id: I5460e5dfa87084c1bd0b72d077e7402fcbb2b7d7
    Partial-Bug: #1663864
    (cherry picked from commit 862d48df34ae909de90db02c84f5ae4d87286072)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/437862
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=8105003afd0d37782b82cbbcdad94c966dda9a8c
Submitter: Jenkins
Branch: stable/ocata

commit 8105003afd0d37782b82cbbcdad94c966dda9a8c
Author: Hong Hui Xiao <email address hidden>
Date: Tue Feb 14 21:45:34 2017 +0800

    Clean the exclude list of flake8

    The exclude list of flake8 is out of date. Update it with latest
    project structure.

    Change-Id: I74bbb234843226a75be81f2662fa6d983644b0f4
    Closes-Bug: #1663864
    (cherry picked from commit 1dabe808375c845923684ae8767c36057fc69b9e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/dragonflow ocata-eol

This issue was fixed in the openstack/dragonflow ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.