RFE: Use revisions plugin for object versions

[Omer Anson]

Currently we maintain a version per object manually. It is done using in the version_db module, and we maintain it ourselves in a df-specific manner.

Neutron have added a revisions service plugin[1]. Instead of implementing versioning ourselves, we should use this service plugin.

It would be best to also solve this bug in small increments, to verify that versions are incremented the way we expect them.

[1] https://review.openstack.org/#/c/303966

[Hong Hui Xiao (xiaohhui)]

I would take this to get familiar with the df resources.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/365935

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/365936

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/365935
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=abe77517785bc427b849777d139ecac464444b02
Submitter: Jenkins
Branch: master

commit abe77517785bc427b849777d139ecac464444b02
Author: Hong Hui Xiao <email address hidden>
Date: Mon Sep 5 16:42:12 2016 +0800

    Use revision_number instead of DFVersionObjects(floatingip)

    This patch also adds unit test for it.

    Change-Id: I675827a45dae2ae0d8e7f1237592e1bb55b586b8
    Partial-Bug: #1618738

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/367718

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/368281

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/368281
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=b5b3a040075467c0898ac910136f6c75aea242ff
Submitter: Jenkins
Branch: master

commit b5b3a040075467c0898ac910136f6c75aea242ff
Author: Hong Hui Xiao <email address hidden>
Date: Sat Sep 10 10:24:22 2016 +0800

    Fix UnboundLocalError when neutron fail to create fip

    [1] removes one line code, which will cause UnboundLocalError, when
    neutron fails to create floatingip.

    This patch fixes that and adds an UT for it.

    [1] https://review.openstack.org/#/c/365935/

    Change-Id: I8a2363be4878c7abeadcc4807b17e95bf69f74b0
    Related-Bug: #1618738

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/374698

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/374842

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/365936
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=57585915af825077588965c5bafe824642180540
Submitter: Jenkins
Branch: master

commit 57585915af825077588965c5bafe824642180540
Author: Hong Hui Xiao <email address hidden>
Date: Tue Sep 6 10:40:47 2016 +0800

    Use revision_number instead of DFVersionObjects(sg)

    Change-Id: Ic269a05a3ffe1e7234f49fd0dae673c0e347a9a9
    Partial-Bug: #1618738

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/380070

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374698
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=26af96bbf1fbb29ef0cfed2c0a6c550e9d8a0160
Submitter: Jenkins
Branch: master

commit 26af96bbf1fbb29ef0cfed2c0a6c550e9d8a0160
Author: Hong Hui Xiao <email address hidden>
Date: Thu Sep 22 19:02:46 2016 +0800

    Use revision_number(network subnet)

    Change-Id: I5617bc29c41777a175065197e17122b81ef7f03d
    Partial-Bug: #1618738

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374842
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=66a2ccbde087c3cb55394e08b4179f41a0424e6c
Submitter: Jenkins
Branch: master

commit 66a2ccbde087c3cb55394e08b4179f41a0424e6c
Author: Hong Hui Xiao <email address hidden>
Date: Thu Sep 22 21:59:51 2016 +0800

    Use revision_number instead of DFVersionObjects(port)

    Change-Id: I14a64348bafd21d82cd723abc3b701e6ff2115a4
    Partial-Bug: #1618738

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/380070
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=175241e2cf55fdf69c9bca6849a24a9ccc88a366
Submitter: Jenkins
Branch: master

commit 175241e2cf55fdf69c9bca6849a24a9ccc88a366
Author: Hong Hui Xiao <email address hidden>
Date: Fri Sep 30 17:40:03 2016 +0800

    Use Ml2PluginV2TestCase to test DFMechDriver

    Ml2PluginV2TestCase was introduced to test revision_number. Actually
    it could be used to test all cases of DFMechDriver. So df don't have
    to fake everything for the UT.

    Change-Id: I7e172d179bcf1ced24e9f1046a07c3850cceb813
    Closes-bug: #1618738

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/367718
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=db8c8a2eac78afacbce84ec2f394924f4bad78e3
Submitter: Jenkins
Branch: master

commit db8c8a2eac78afacbce84ec2f394924f4bad78e3
Author: Hong Hui Xiao <email address hidden>
Date: Fri Sep 9 09:36:50 2016 +0800

    Get updated revision_number from AFTER_DELETE event

    Since neutron adds sg_id to AFTER_DELETE event of sg rule[1], we
    can remove the workaround added before.

    [1] https://review.openstack.org/#/c/367728/

    Related-Bug: #1618738
    Change-Id: Iffcbd45145e9bf5bd7a94338397c63441270ff16