support admin-state of port

Bug #1568739 reported by Li Ma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DragonFlow
Fix Released
High
Eyal Leshem

Bug Description

currently admin-state is not supported for port updating.

for example, in selective distribution:

https://github.com/openstack/dragonflow/blob/master/dragonflow/controller/topology.py#L45

It should check whether port's admin-state-up is true or false. We need to support the state changing from true to false and from false to true as well.

ugvddm (271025598-9)
Changed in dragonflow:
assignee: nobody → ugvddm (271025598-9)
Revision history for this message
ugvddm (271025598-9) wrote :

why do detemine in https://github.com/openstack/dragonflow/blob/master/dragonflow/controller/topology.py#L45, not in https://github.com/openstack/dragonflow/blob/master/dragonflow/controller/df_local_controller.py#L191?

port's admin-state-up will be updated by neutron-server, not by nova or l3-agent, which will call ovs_port_updated(), for example, nova will create an ovs interface when create vm, this is my understand maybe wrong, : )

Revision history for this message
Li Ma (nick-ma-z) wrote :

sorry for misunderstanding. i used a wrong verb, not 'determine', but 'check'. i just give an example, not implementation. port's admin-state-up can also be changed via api, afaik.

description: updated
Omer Anson (omer-anson)
Changed in dragonflow:
importance: Medium → High
Omer Anson (omer-anson)
Changed in dragonflow:
assignee: ugvddm (271025598-9) → nobody
Eyal Leshem (leyal)
Changed in dragonflow:
assignee: nobody → Eyal Leshem (leyal)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to dragonflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/508725

Changed in dragonflow:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to dragonflow (master)

Reviewed: https://review.openstack.org/508725
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=e05d715d2b918496f8eb1ec2224eafb8808e1b55
Submitter: Zuul
Branch: master

commit e05d715d2b918496f8eb1ec2224eafb8808e1b55
Author: Eyal Leshem <email address hidden>
Date: Sun Oct 1 11:55:23 2017 +0300

    support admin-state of port

    bind_port only when it's in admin_state_up
    unbind it when it's admin_state_down

    Change-Id: I1f336e397d9cd61cd294a655498f202a859d1e9c
    Closes-Bug: #1568739

Changed in dragonflow:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.