incorrect dhcp port for IPv4 subnet

[shihanzhang]

Now the default value of config option 'use_centralized_ipv6_DHCP' is True, when we create a IPv4 subnet, it will directly use first IP address in allocation_pools, but I think we should check if the subnet is IPv6, the codes as below:

    def _handle_create_subnet_dhcp(self, context, subnet):
        """Create the dhcp configration for the subnet

        Returns the dhcp server ip address if configured
        """
        if subnet['enable_dhcp']:
            if cfg.CONF.df.use_centralized_ipv6_DHCP:
                return subnet['allocation_pools'][0]['start']
            else:
                dhcp_port = self._create_dhcp_server_port(context, subnet)
                return self._get_ip_from_port(dhcp_port)
        return None

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/273371

[OpenStack Infra (hudson-openstack)]

Change abandoned by shihanzhang (<email address hidden>) on branch: master
Review: https://review.openstack.org/273371
Reason: agree

[Omer Anson (omer-anson)]

This bug has to be verified - It is possible we no longer need the code causing this bug.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/503965
Committed: https://git.openstack.org/cgit/openstack/dragonflow/commit/?id=8619ce71c54a7e0986eb375d1fa32599e49b7362
Submitter: Zuul
Branch: master

commit 8619ce71c54a7e0986eb375d1fa32599e49b7362
Author: Eyal Leshem <email address hidden>
Date: Wed Sep 6 14:22:45 2017 +0300

    DHCP port per network

    Until this patch dhcp_port created per subnet
    This patch change this behaviour to - one port per network

    For full details see :
    https://github.com/openstack/dragonflow/blob/master/doc/source/specs/dhcp_port_per_network.rst

    Change-Id: I25c6a6876945c9e6ee10887e8900564692455258
    Closes-Bug: #1725983
    Closes-Bug: #1531377