Remote Share directory listing chokes when remote filenames contain unicode characters

[Jeremy Jongsma]

When browsing remote shares, if a filename contains a non-ascii unicode character, the listing chokes.

Sample error:

Could not retrieve directory listing
u'\xe9'

[j (j-sassinak)]

Assuming that by "Remote Share" you are talking about the page you get to by clicking on "Media Browser" this patch should fix it and various other problems that I had with displaying unicode.

[Jeremy Jongsma (jeremy-jongsma)]

Thanks j, I'll try it out this week.

I'm not much of a unicode expert and that fact the Twisted doesn't deal with unicode well natively has made it a bit of a pain in the butt.

[j (j-sassinak)]

I think that more than just being a problem with twisted, it's a problem with how well Python 2.x handles unicode. I hear that Python 3.x does a lot better with it though.

Basically it was just trial and error for getting it to work. Hopefully I didn't do something that just worked on my machine but will fail elsewhere.

[Jeremy Jongsma (jeremy-jongsma)]

Committed, there's probably a few other places that need this yet too, when I get some time I'll split off the safe_unicode stuff into a shared module.