add unit test for Dot.py replacement()

Bug #1023564 reported by Kyle Nitzsche
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dotdepends
Medium
Mike Carifio

Bug Description

1) replacement() should be have a unit test that verifies a range of known invalid dot node names are returned as valid dot node names.

2) the function should have a more descriptive name, perhaps pkg2dotNode(),.

3) Extra credit, the Dot class should perhaps have a dictionary whose key is the node name and whose value is the pkg name.

Related branches

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Mike, if interested... a unit test here. Else assign back to me.

Changed in dotdepends:
assignee: nobody → Mike Carifio (carifio)
Revision history for this message
Mike Carifio (carifio) wrote :

Merge proposal https://code.launchpad.net/~carifio/dotdepends/dotdepends-unittests/+merge/114513 addresses testing Dot.replacement(). The other two items should come later when we have more time to do a full unit test for the Dot object. The scaffolding is in place.

Mike Carifio (carifio)
Changed in dotdepends:
status: Confirmed → Fix Committed
Mike Carifio (carifio)
Changed in dotdepends:
status: Fix Committed → In Progress
Revision history for this message
Mike Carifio (carifio) wrote :

Committed dotdepends -r 83, version 3.8.19

Changed in dotdepends:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers