DockManager incompatibility

[Jiří Janoušek]

Docky 2.1.4 bzr docky r1810 from ppa:docky-core/stable

There are wrong signatures in interface net.launchpad.DockItem:
 * method AddMenuItem
 * method RemoveMenuItem
 * signal MenuItemActivated

Docky uses uint32 type for menu item id, however, DockManager API descriptions [1][2] specifies int32 type.

[1] http://wiki.awn-project.org/Dbus_Backend_API
[2] http://wiki.go-docky.com/index.php?title=Writing_Helpers#DBus_Interface_Specification

[Robert Dyer (psybers)]

I don't think this causes any problems. And most likely, the spec is just wrong. I think menu ids should be unsigned.

[Robert Dyer (psybers)]

Ok so, Michal and I discussed and decided that yes the spec is wrong and should be unsigned. So in v2 of the spec, this should be fixed.

As such, Docky will just remain using the unsigned.

[Jiří Janoušek (fenryxo)]

> I don't think this causes any problems.

In Vala language I had to create two DBus interfaces for DockItem - the first one for Docky (with uint32) and the second one for AWN and DockBarX (with int32) - and switch between them according to running dock. Otherwise I'll get DBus errors that method with this signature has not been found.

> So in v2 of the spec, this should be fixed.

Great :-) I hope there will be a way how to determine which version of specification is used by currently running dock. Thanks.