Do

ExecuteWithArguments doesn't execute immediately

Bug #811366 reported by Theodore Lee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Do
Fix Released
Undecided
Unassigned

Bug Description

When passing arguments to xargs, ExecuteWithArguments doesn't close the standard input stream after writing the last argument. As a result, when multiple arguments are passed the command is not executed, and Do hangs when exiting. Sending SIGTERM to Do does seem to close the streams and run any pending commands (so you can try a bunch of copy operations with the Files and Folders plugin, but they won't actually execute until you run 'killall gnome-do').

The attached patch fixes this problem by closing the standard input stream after passing arguments to xargs. It also fixes a minor logging issue (log messages would list the arguments, but not the actual command).

Related branches

Revision history for this message
Theodore Lee (sharp-shiny) wrote :
Revision history for this message
Chris Halse Rogers (raof) wrote :

Thanks for the patch. Committed.

Does this mean we've got an active Fedora Do maintainer? ☺

Changed in do:
status: New → Fix Committed
Revision history for this message
Theodore Lee (sharp-shiny) wrote :

> Does this mean we've got an active Fedora Do maintainer? ☺

Indeed it does, albeit a dangerously inexperienced one. =)

Changed in do:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.