Do

Evolution-sharp dependency should not be mandatory

Bug #195678 reported by Arun Raghavan
2
Affects Status Importance Assigned to Milestone
Do
Fix Released
Low
Unassigned
Gentoo Linux
Fix Released
Medium

Bug Description

There should be a way for me to use the other plugins even if I don't want Evolution and evolution-sharp on my system. Here's a patch to make compilling the Evo plugin optional.

Please let me know if any changes are required. If this is okay, I'll write a patch to make the other plugins optional too.

Thanks for the great tool!

Revision history for this message
Arun Raghavan (arunraghavan) wrote :
Revision history for this message
Chris Halse Rogers (raof) wrote :

Thank you very much for doing the work that I've meant to do, but never quite got around to doing! (And somewhat better than I would have done it, too).

The patch looks good to me. Feel free to create the patch to make other plugins optional, but it's probably only worth bothering with plugins that have dependencies other than do.addins or do.dbus. Do will soon be growing (the mono.addins branch has much of the work done) a way to configure the loading and unloading of plugins. The extra optional plugins patch will presumably use a ENABLED_SUBDIRS and +=, rather than multiple variables, yes?

I'll wait for the extended patch before committing.

Changed in gc:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Arun Raghavan (arunraghavan) wrote :

Evolution seems to be the only plugin with a compile-time dependency, so this patch should suffice for the purpose of being able to minimise compile-time dependencies.

I started looking at this while writing an ebuild for Gentoo. Ideally, I think there should be an option to disable each plugin (all plugins can be selected by default), so that people who want only a specific set of plugins can choose this. Would this be fine?

Thanks for the feedback!

Revision history for this message
Arun Raghavan (arunraghavan) wrote :

Just in case this is fine, here's the patch.

Revision history for this message
Chris Halse Rogers (raof) wrote : Re: [Bug 195678] Re: Evolution-sharp dependency should not be mandatory

I'll ask some other Do developers about this. I personally think this
complicates the build system a bit, for little benefit, but I'll ask
around.

Revision history for this message
Arun Raghavan (arunraghavan) wrote :

As discussed on IRC, here's a patch that makes only those plugins that depend on libs other than Do.(Addins|DBus} optional.

Changed in gc:
status: Triaged → Fix Committed
Jorge Castro (jorge)
Changed in do:
status: Fix Committed → Fix Released
Changed in gentoo:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.