Twitter plugin no longer receives updates, and all posts report failure despite success

Reported by Alex Launi on 2009-06-15
24
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Do Plugins
High
Alex Launi
gnome-do-plugins (Ubuntu)
Medium
Iain Lane
Jaunty
Medium
Unassigned

Bug Description

After the 'twitpocalypse' the twitter plugin (an extremely popular and visible plugin) for GNOME Do is entirely broken. This is dude to integer overflow in twitter post ids, and has a simple fix of using a long instead of an int for the post id.

TEST CASE:
Reproducing this bug is very simple, try to post anything to twitter from GNOME Do.

1. sudo aptitude install gnome-do gnome-do-plugins
2. launch gnome-do
3. enable microblogging plugin
4. enter your twitter credentials in the microblogging configuration dialog
5. Summon Do with <Super>space
6. Type your message to post to twitter
7. hit tab and search for "post to twitter"
8. press enter to send message
9. See failed message
10. go to twitter.com and see that the message posted

Although the post is successful, it reports a failure due to the XML reply reporting a negative post id from 32bit integer overflow. This negative post id also affects incoming messages and prevents them from being shown, so users are not receiving any timeline updates.
All users are affected.

Alex Launi (alexlauni) wrote :

Changes int post ids to long

Changed in do-plugins:
assignee: nobody → Alex Launi (alexlauni)
importance: Undecided → High
milestone: none → 0.8.2
status: New → Confirmed
Alex Launi (alexlauni) on 2009-06-15
description: updated
Iain Lane (laney) on 2009-06-15
Changed in gnome-do-plugins (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Alex Launi (alexlauni) on 2009-06-15
description: updated
haran_elessar (david-spike) wrote :

I will download the patch when I get home to my laptop. I just wanted to add that I'm getting notifications for direct messages. Although they do appear twice in succession. Everything else behaves exactly as reported in the bug. If everyone else is also able to see notifications for direct messages I think it should be added to the main bug report.

Notifications for DMs don't suffer from this because they're not connected
to the timeline and therefore dont have an astronomically high ID number. If
you're getting doubles, please file a seperate report and I'll check into
that.

--
--Alex Launi

Iain Lane (laney) on 2009-06-15
Changed in gnome-do-plugins (Ubuntu):
assignee: nobody → Iain Lane (laney)
status: Triaged → In Progress
haran_elessar (david-spike) wrote :

At first I thought it shouldn't be a related bug for the same reason you stated. But it did happen the same day of "twitpocalypse"...it had never happened before...so I thought it was related somehow. But weird bug aside I just got home and it's no longer sending double notifications for directs. I will refrain from filing another report and you guys/gals can just ignore my first message.

have a good day...and I just wished I knew how to code to help out with these sort of fixes...

description: updated
Iain Lane (laney) on 2009-06-16
Changed in gnome-do-plugins (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-do-plugins - 0.8.1.3+dfsg-2ubuntu2

---------------
gnome-do-plugins (0.8.1.3+dfsg-2ubuntu2) karmic; urgency=low

  * debian/patches/20_twitter_overflow.dpatch: Backport patch from upstream
    bzr (and Debian SVN) to fix broken Twitter message sending. The number of
    messages posted to Twitter has overflowed the size of an int(!), so these
    variables have been converted to longs. (LP: #387525)

 -- Iain Lane <email address hidden> Tue, 16 Jun 2009 01:06:39 +0100

Changed in gnome-do-plugins (Ubuntu):
status: Fix Committed → Fix Released
Iain Lane (laney) wrote :

Here is the debdiff for jaunty-proposed. Please approve it.

ACK.

Please update debian/patches/20_twitter_overflow.dpatch to include a description instead of "## DP: No description" on upload though.

Iain Lane (laney) wrote :

Done and uploaded. Thanks.

Changed in gnome-do-plugins (Ubuntu Jaunty):
importance: Undecided → Medium
status: New → Fix Committed
Jonathan Riddell (jr) wrote :

accepted into jaunty-proposed, please test

Daniel Holm (danielholm) wrote :

To enable proposed, do I do that in the "main" repo or just for Gnome-Do?

Iain Lane (laney) wrote :

Daniel, See https://wiki.ubuntu.com/Testing/EnableProposed for information on how to enable proposed to get the update.

Please note additionally that, due to a limitation in gnome-do (to be fixed for Karmic), you will have to remove or move the .local/share/gnome-do/plugins-0.8.1.3/ and then re-enable the plugin for the fix to show up. This will blow away all of your settings, unfortunately.

Thanks,
Iain

The fix did the trick for me in Jaunty! :-)

Daniel Holm (danielholm) wrote :

I have enabled jaunty-proposed, but have not got the update yet...

Thank you! :)

Daniel Holm (danielholm) wrote :

Never mind - it works perfectly again.

It worked for me too!. It's amazing how quick you can fix something in an open source project. That's one (of many) of the reasons that I love it :).

Thanks again! =)

Iain Lane (laney) on 2009-06-23
tags: added: verification-done
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-do-plugins - 0.8.1.3+dfsg-0ubuntu3.1

---------------
gnome-do-plugins (0.8.1.3+dfsg-0ubuntu3.1) jaunty-proposed; urgency=low

  * debian/patches/20_twitter_overflow.dpatch: Backport patch from Karmic
    -2ubuntu2 versionto fix broken Twitter message sending. The number of
    messages posted to Twitter has overflowed the size of an int(!), so these
    variables have been converted to longs. (LP: #387525)

 -- Iain Lane <email address hidden> Tue, 16 Jun 2009 12:51:22 +0100

Changed in gnome-do-plugins (Ubuntu Jaunty):
status: Fix Committed → Fix Released
Alex Launi (alexlauni) on 2009-07-09
Changed in do-plugins:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers