Microbloggin Plugin - Support to Laconi.ca based.

Bug #347724 reported by Glauco Vinicius
2
Affects Status Importance Assigned to Milestone
Do Plugins
Confirmed
Wishlist
Unassigned

Bug Description

Hello people,

I wrote some code to use Microblogging plugin with other Laconi.ca based Servers.

I think that it needs some revision and more tests, but, it works fine with me!

Thanks for the comprehension!

At
Glauco Vinicius

Revision history for this message
Glauco Vinicius (glaucovinicius) wrote :
Revision history for this message
Alex Launi (alexlauni) wrote :

Patch comments:
Why did you modify Makefile.include? Was that done by monodevelop perhaps?
You should also add yourself to the list of authors in the addin manifest (the addin.xml file).
In your configuration UI, maybe use a ComboEntry instead of a combobox, and an entry. This will be a lot cleaner of a UI.
You changed a couple uses of "" to string.Empty, change them back. We use "", not string.Empty.
There seems to be a typo in Preferences.cs, you have: const string MicroblogServiceAddressKey = "{0}/ServiceAddres"; <-- note the missing 's'
You added a debugging writeline to Urls.cs, remove it. Remove any other WriteLines I missed, if it's debugging you want to leave, use the Log<T>.Debug () method (or similar).

There may be more issues, fix these then I will re-review. I haven't actually tested/applied the patch, this was just a review of the patch itself.

Changed in do-plugins:
importance: Undecided → Wishlist
status: New → In Progress
tags: added: microblogging official-plugins
Alex Launi (alexlauni)
Changed in do-plugins:
status: In Progress → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.