Polish docky's window name labels

Reported by Dusan Maliarik on 2009-01-18
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Do
Wishlist
Jason Smith
Do Plugins
Undecided
Unassigned

Bug Description

More precise labels for window names in docky theme. rounded corners of background should be of same radius as icon area's background, and text should have a drop shadow for better contrast.

Dusan Maliarik (dusan-maliarik) wrote :
Dusan Maliarik (dusan-maliarik) wrote :

imho, this looks much better

Dusan Maliarik (dusan-maliarik) wrote :

...patch

This is very nice work, and much easier to read. Jason can make the
call -- maybe incorporate some if not all of these changes.

Jason Smith (jassmith) wrote :

I agree, this is much better. I will incorporate these changes as well as updates for positional docks

Jason Smith (jassmith) wrote :

This patch (on further review) gives me really ugly fonts...

Dusan Maliarik (dusan-maliarik) wrote :

that's probably because you have som non standard fonts set as default. Font is the same as before, only it is not bold. I suppose it's default sans-serif font.

Anyway, will there be some UI to set theme's options? I mean each theme with it's own option set. Font, background color, icon sizes...

Dusan Maliarik (dusan-maliarik) wrote :

Jason, is there a reason to not fix this?

Dusan Maliarik (dusan-maliarik) wrote :

there's also issue with current code, taht it cuts background if text is long. see attached screenshot

Jason Smith (jassmith) wrote :

Please try out the branch associated with this bug. While it does not contain a faithful import of your patch (because I have bigger plans for this) I have imported most of it. I have kept it bold (for now) because it is readable on more default fonts. However once I get proper system text going, this will be a non issue and the non-bold will be default.

There is also now an outline on the tooltip that is consistent with an outline on the popup menu. These were added due to negative feedback on the look and feel of docky with dark backgrounds.

Jason

Jason Smith (jassmith) wrote :

One more thing, sorry about the delay in response. I just didn't want to say anything until I had this branch online.

Jason Smith (jassmith) wrote :

It is in the next release (with some modifications. Will add Dusan to contributors list.

Changed in do:
assignee: nobody → jassmith
importance: Undecided → Wishlist
milestone: none → 0.8.1
status: New → Fix Committed

great idea with that outline, it's perfect now

Robert Dyer (psybers) on 2009-07-03
Changed in do-plugins:
status: New → Invalid
Changed in do:
status: Fix Committed → Fix Released
Mirco Müller (macslow) wrote :

I know this bug has been closed, but I still wanted to add this here (and not open a new bug). If someone feels motivated enough s/he can go and salvage the code from ...

http://bazaar.launchpad.net/~macslow/notify-osd/blur-cache/annotate/head%3A/tests/test-tile.c

... in order to further beautify the text-rendering in those labels. Should you have any questions regarding the code there, just ask. See the attached screenshot for an example rendering.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers