dkms.conf can be broken in subtle ways the sourcing the file miss

Bug #599980 reported by Peter Petrakis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DKMS
New
Undecided
Unassigned

Bug Description

Take the following config file for example

PACKAGE_NAME="alsa-driver-hda-intel"
PACKAGE_VERSION="2.6.32"
AUTOINSTALL="yes"
OBSOLETE_BY="2.6.35"

MAKE="make KVER=$kernelver
CLEAN="make KVER=$kernelver clean

BUILT_MODULE_NAME[0]="snd-hda-codec-analog"
BUILT_MODULE_LOCATION[0]="./"
DEST_MODULE_LOCATION[0]="/updates/kernel/sound/pci/hda"

There's a double quote missing from the end of MAKE & CLEAN

(lucid-i386)root@nautilus:~# source dkms.conf
-bash: clean: command not found
(lucid-i386)root@nautilus:~# echo $?
0

While dkms normally checks the return value when it sources the conf file, plain
syntax errors like this sometimes get through. This caused some strange errors
for me later in the build (it did build) which were not readily identifiable.

dkms should actually parse the config file and verify at least basic shell syntax
e.g. proper variable name + equals sign + double quoted expression

Revision history for this message
Jerone Young (jerone) wrote :

What is the behavior if you run this file though dkms right now? Does it fail and give you an error message?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.