Cannot sign messages without a DNS resolver installed

Bug #847669 reported by Petri Lehtinen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dkimpy
Status tracked in Trunk
Trunk
Fix Released
Wishlist
Stuart Gathman

Bug Description

Only message verifying requires DNS resolving. However, pydkim wants to import such a library even if pydkim is only used for signing. It would be nice to fire the DNS resolver imports only when verify() is actually called.

Petri Lehtinen (petri)
description: updated
description: updated
Changed in pydkim:
importance: Undecided → Wishlist
Changed in pydkim:
assignee: nobody → Stuart Gathman (stuart-gathman)
milestone: none → 0.4.2
status: New → Fix Committed
Revision history for this message
Stuart Gathman (stuart-gathman) wrote :

Revision 76 make dns library import optional. Signing (and even verify that doesn't make it to the DNS lookup, e.g. body hash mismatch) works with no dns library. In case a verify is attempted and DNS is required and missing, this exception is raised:

RuntimeError: DKIM.verify requires DNS or dnspython module

Revision history for this message
Petri Lehtinen (petri) wrote :

Great, thanks!

Revision history for this message
Scott Kitterman (kitterman) wrote :

2012-02-03 Version 0.5.1
    - Rename tarball to dkimpy to avoid confusion with original project
    - Apply performance patch from <https://launchpad.net/bugs/901591>
    - save parsed signatures in DKIM object
    - do not require DNS/dnspython for signing

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.