Mangled AAR header when srv_id is a suffix of some AR header fields

[Nikolay]

Here's an example of the generated AAR header from the existing AR header (produced by ARC.sign method):

ARC-Authentication-Results: i=1; 10-69-43-116.qa.plesk.tech; dmarc=pass (p=QUARANTINE sp=NONE) smtp.from=test1.10-69-43-116.qa.plesk.tech header.from=test1.
        dkim=pass header.d=test1.
        spf=pass (sender IP is 127.0.0.1) <email address hidden> smtp.helo=webmail.test1.10-69-43-116.qa.plesk.tech
Authentication-Results: 10-69-43-116.qa.plesk.tech;
        dmarc=pass (p=QUARANTINE sp=NONE) smtp.from=test1.10-69-43-116.qa.plesk.tech header.from=test1.10-69-43-116.qa.plesk.tech;
        dkim=pass header.d=test1.10-69-43-116.qa.plesk.tech;
        spf=pass (sender IP is 127.0.0.1) <email address hidden> smtp.helo=webmail.test1.10-69-43-116.qa.plesk.tech

Note that some semicolons are missing and trailing parts of header.from and header.d are missing as well. For the purposes of this result srv_id = b'10-69-43-116.qa.plesk.tech' in the call to the library.

I believe this can be fixed by the following change in the library code:

- results_lists = [raw.replace(srv_id + b';', b'').strip() for (raw, parsed) in auth_headers]
+ results_lists = [raw.replace(srv_id + b';', b'', 1).strip() for (raw, parsed) in auth_headers]

Library version: dkimpy==1.1.5

Original API call:

r = arc.sign('default'.encode(), 'test1.10-69-43-116.qa.plesk.tech'.encode(), key, '10-69-43-116.qa.plesk.tech'.encode())

[Scott Kitterman (kitterman)]

It looks like this is OBE to your proposed change in #2052526, which I have applied. Please let me know if there's anything still needed for this bug?

[Launchpad Janitor (janitor)]

[Expired for dkimpy because there has been no activity for 60 days.]

[Nikolay (nvizovitin)]

> It looks like this is OBE to your proposed change in #2052526

I'm not sure what you mean. #2052526 doesn't seem to exist.

Anyway, that's a separate issue from the others I've reported.

[Scott Kitterman (kitterman)]

Sorry. I got the bug number wrong. I meant https://bugs.launchpad.net/dkimpy/+bug/2052528

The code you want changed in this bug was otherwise modified. See commit 9380655a6ec29a5ae0992c609ac199ebb8e3d762.

Let me know what needs to be done with this now (if it's different change now, that's fine).

[Nikolay (nvizovitin)]

Yes, sorry for the confusion. Patch from #2052528 already accounts for this issue and the commit you've listed should be enough to resolve it as well.

So, I suppose, nothing else should be done here.

[Scott Kitterman (kitterman)]

Thanks.