"From" header missing from SHOULD
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dkimpy |
Fix Released
|
High
|
Scott Kitterman |
Bug Description
According to RFC 4871 section 5.4, Recommended Signature Content, "From" "SHOULD be included in the signature." However, dkim.DKIM.SHOULD does not include this.
For example,
In [10]: dkim.DKIM.SHOULD
Out[10]:
('sender',
'reply-to',
'subject',
'date',
'message-id',
'to',
'cc',
'mime-version',
'content-type',
'content-
'content-id',
'content- description',
'resent-date',
'resent-from',
'resent-sender',
'resent-to',
'resent-cc',
'resent-
'in-reply-to',
'references',
'list-id',
'list-help',
'list-
'list-subscribe',
'list-post',
'list-owner',
'list-archive')
From is listed in dkim.DKIM.
Tested in version 0.5.4.
Changed in dkimpy: | |
milestone: | none → future |
That's interesting, but From is actually a mandatory header, so putting it in the SHOULD list would be redundant. (Although it shouldn't break anything.) We could have a MANDATORY list, but From seems to be the only really mandatory header.