bytearray index out of range in DKIM.verify()

[Stuart Gathman]

2013Feb26 18:49:11 check_dkim: bytearray index out of range
Traceback (most recent call last):
  File "bms.py", line 1877, in check_dkim
    res = d.verify()
  File "/usr/lib/python2.6/site-packages/dkim/__init__.py", line 546, in verify
    pk = parse_public_key(base64.b64decode(pub[b'p']))
  File "/usr/lib/python2.6/site-packages/dkim/crypto.py", line 112, in parse_public_key
    x = asn1_parse(ASN1_Object, data)
  File "/usr/lib/python2.6/site-packages/dkim/asn1.py", line 57, in asn1_parse
    tag = data[i]
IndexError: bytearray index out of range

[Stuart Gathman (stuart-gathman)]

Unfortunately, my milter does not capture the DNS record. It works now, so they must have fixed it. Now I'll have to tinker to find how to break it in a similar way. In addition to a test case and fix, the goal is to save the raw DNS record on exceptions involving the public key.

[Stuart Gathman (stuart-gathman)]

Committed test case and fix as revision 102.

[Scott Kitterman (kitterman)]

Fixed in 0.5.4.