django-openstack-auth

policy check short circuiting after first rule

Bug #1643082 reported by David Lyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
django-openstack-auth
Fix Released
High
David Lyle

Bug Description

The check method in policy.py was designed to take multiple actions. With the domain scoped token support addition, this was broken to short circuit the results on the first rule result regardless of pass or fail.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to django_openstack_auth (master)

Fix proposed to branch: master
Review: https://review.openstack.org/399792

Changed in django-openstack-auth:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to django_openstack_auth (master)

Reviewed: https://review.openstack.org/399792
Committed: https://git.openstack.org/cgit/openstack/django_openstack_auth/commit/?id=b8567d60602280aba294cbea99dbf10c9bbb321b
Submitter: Jenkins
Branch: master

commit b8567d60602280aba294cbea99dbf10c9bbb321b
Author: David Lyle <email address hidden>
Date: Fri Nov 18 15:45:22 2016 -0700

    Fix policy check short circuit

    The check() method was broken during a refactor and now only
    checks the first result in the list and then returns that result.

    This patch restores the AND functionality of check and only short
    circuits on a failed result.

    Closes-Bug: #1643082
    Change-Id: I7d976299de2a35b81ced29d2c3f265da62f20eff

Changed in django-openstack-auth:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/django_openstack_auth 3.1.0

This issue was fixed in the openstack/django_openstack_auth 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.