django-openstack-auth uses sets suboptimally in multiple places.

Bug #1506925 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
django-openstack-auth
Fix Released
Undecided
Kirill Zaitsev

Bug Description

In many places throughout the code sets are constructed from list comprehensions. Since django-openstack-auth only supports py27 and does not support py26 — we could use set comprehensions to improve both coding style and slightly improve speed.

Changed in django-openstack-auth:
assignee: nobody → Kirill Zaitsev (kzaitsev)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to django_openstack_auth (master)

Reviewed: https://review.openstack.org/216441
Committed: https://git.openstack.org/cgit/openstack/django_openstack_auth/commit/?id=885cdd96c630fa225a2e7417f541ddfeb335bd89
Submitter: Jenkins
Branch: master

commit 885cdd96c630fa225a2e7417f541ddfeb335bd89
Author: Kirill Zaitsev <email address hidden>
Date: Tue Aug 25 01:02:28 2015 +0300

    Use set comprehension instead of converting lists to sets

    This patch takes advantage of python set comprehensions
    syntax instead of constructing a list and converting
    it to set later.
    Also takes advantage of .isdisjoint function,
    that returns True if two sets have a null intersection.
    Should slightly improve performance and readability.

    Closes-Bug: #1506925
    Change-Id: Ia3d8b47efcf1b2280d7570e782fd196ce716ac8a

Changed in django-openstack-auth:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/django_openstack_auth 2.1.1

This issue was fixed in the openstack/django_openstack_auth 2.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.