openid usernames not using valid django characters

[Stuart Metcalfe]

When using the username supplied by the openid provider, we should remove or substitute characters not valid for django usernames. An example of this is if you have a hyphen character in your launchpad username. You are able to login to the django site and your username is accepted and stored but attempts to edit the user in the admin ui result in an error from django stating that the username contains invalid characters.

[nbv4 (nbvfour)]

heres a quick fix for this one (untested)

[Chris Beaven (smileychris)]

http://code.djangoproject.com/changeset/12634 introduces a more relaxed set of [\w.@+-]

The username probably should also be truncated to 30 characters (and you'd need to truncate to less when adding numbers to find a unique username too)

[Michael Nelson (michael.nelson)]

As per bug 746353, we could also just modify the validation for the admin user form - the openid usernames are fine in terms of model-level validation, it's just the admin form uses a slug form field for validation. That way we'd not be losing info (in most cases, not when we have username clashes from different providers).