__conform__ should not require a store
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Divmod |
Fix Released
|
Medium
|
Laurens Van Houtven |
Bug Description
Empowered.
for persisted powerups (obviously), but it means that the following
doesn't work:
>>> rodimus = Transformer(
>>> hotRod = HotRod(color=u"Red and yellow")
>>> rodimus.
>>> assert ICar(rodimus) is hotRod
Traceback (most recent call last):
...
TypeError: ('Could not adapt', ...)
You can see this in action here:
https:/
The reason it doesn't work is that __conform__ craps out.
I think this is a bug, because the docstring for __conform__ appears
to suggest that it should just use the first powerup from powerupsFor;
but that uses _inMemoryPowerups before looking at stored powerups,
exactly as the inMemoryPowerup docstring suggests as well.
Related branches
- Tristan Seligmann: Approve
-
Diff: 93 lines (+34/-20)2 files modifiedAxiom/axiom/item.py (+16/-14)
Axiom/axiom/test/test_powerup.py (+18/-6)
Changed in divmod.org: | |
status: | New → In Progress |
importance: | Undecided → Medium |
Changed in divmod.org: | |
status: | Fix Committed → Fix Released |
Does anything still needs to happen for this to be able to be merged? ISTR that this was hashed out on the mailing list and that it was good to go.