track name with a question mark in it causes a seg-fault

[Robert Hart]

Binary package hint: sound-juicer

Edgy Sound-juicer on an up to date install.

If track name has a question mark in it, then seg fault upon hitting extract button. Hitting the play button works as expected.

Command line output:

rhart@rhart-desktop:~$ sound-juicer

(sound-juicer:11076): GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed
Segmentation fault (core dumped)

No sign of a core file in current directory.

[ville palo (vi64pa)]

If you first run: "ulimit -c unlimited" and then sound-juicer core dump should appear in current directory.

[Sebastien Bacher (seb128)]

Thanks for your bug. The apport or bug-buddy packages should detect the crash. You can also run sound-juicer with gdb as described on https://wiki.ubuntu.com/Backtrace to get a backtrace

[Sebastien Bacher (seb128)]

Thanks for your bug report. Could you please try to obtain a
backtrace by following the instructions on
       http://wiki.ubuntu.com/DebuggingProgramCrash.
This will greatly aid us in tracking down your problem.

[Florent Mertens (givre)]

Hi,

I have the exact same problem.
In fact the segfault occur when track, album or artist field contain one of those character ? : "

It seams also to be a duplicate of #70147 even if the error message is not the same (probably because it's not the same version of sound-juicer)

The problem is easy to reproduce.
1. Put an audio CD
2. Open sound-juicer
3. Change one of the field so it contain one of those character ? : "
4. Extract the track

Exemple with a track name : "Track 1 ?"
that should normaly go to / home/flo/documents/Ma Musique/Unknown Artist/Unknow Title/01 - Track 1 ?.ogg
You get the error :

"Sound Juicer could not extract this CD.
Reason: Could not open vfs file "file:///home/flo/documents/Ma Successusique/Unknown0X1.CB0C100000001P+81rtist/Unknown%20Title/01%20-%20Track%2061115106048611626638114816.000000.ogg" for writing: Invalid parameters."

I use https://wiki.ubuntu.com/Backtrace to get a backtrace of the failure. The file is attach to the bug report.
Tell me if you need more.

Thanks.

[Sebastien Bacher (seb128)]

What version of Ubuntu do you use? Could you get a backtrace with libglib2.0-0-dbg libgtk2.0-0-dbg sound-juicer-dbgsym installed?

[Florent Mertens (givre)]

Thanks for the reply.
I use edgy, sound-juicer 2.16.1

With the same procedure than before but with libglib2.0-0-dbg libgtk2.0-0-dbg, (i already had sound-juicer-dbgsym), i get this backtrace.

[Robert Hart (sasallys)]

Hi,

Sorry for not getting back on to this since I logged the bug - life suddenly got hectic.

Thanks, Florent for steeping in. I am happy to provide a core dump too, should it be required.

Other stuff I forgot to mention was that I was extracting directly on to my IAUDIO mp3 player, i.e. I set the music folder in preferences to go there. So, the destination is a vfat volume. I also did not have the "strip special characters" option checked. Having that checked solves the issue.

Let me know if you would like a core dump from me too
Robert

[Florent Mertens (givre)]

Hi robert,

After reading your post, specially the fact that you rip your track on a fat32 fs, like me, i was thinking that it could be the problem.
So i try to extract a track name "track 1 ?" on an ext3 fs, and it works. So this is the cause of the crash, but i don't know why it's happens.

I mount my partition with the above locale option :
codepage=850,iocharset=utf8

While try to mount it with others locale.

Flo

[Florent Mertens (givre)]

Changing iocharset and codpage to default didn't change anything.

On a side not, i have no problem when extracting to my ntfs partition (with utf8 locale).

No idea what's wrong here.

[Robert Hart (sasallys)]

http://en.wikipedia.org/wiki/File_Allocation_Table

Specifically the directory table section
http://en.wikipedia.org/wiki/File_Allocation_Table#Directory_table

<quote>
This excludes the following ASCII characters:

    * " ' * / : < > ? \ |
</>

You can prove this to yourself by changing to a vfat directory and trying to create a file with a ? in the name.

Robert

[Florent Mertens (givre)]

Wha, that's a shame, good work robert ;) .
So there is nothing to do about it.

However, i think that sound-juicer should provide a better error message for this kind of error, and not crash.

Flo

[Sebastien Bacher (seb128)]

Right, sound-juicer should not crash, that's why there is a bug open upstream

[Robert Hart (sasallys)]

Thanks, Sebastien

[akadruid (thedruid)]

Hi,

I think I have a very similar problem. CD artist is 'Hillsongs + Delirious?'. Other CDs work fine. Ubuntu 6.10 Edgy and Sound Juicer 2.16.1

On clicking Extract I get:
Sound Juicer could not extract this CD.
Reason: Could not open CD device for reading.

Followed by:
Sound Juicer could not extract this CD.
Reason: Could not open CD device for reading.

Followed by:
Problem report for sound-juicer... with the attached .crash file

Changing the artist does not prevent this.

[Eric Amundson (sewmyheadon)]

I had a similar problem ripping from a CD that had two blank track names. Once SoundJuicer got to the first nameless track, it choked and crashed. Not sure if this is caused by the same issue, but sounds like it could be.

I can get around this error by simply typing in track names for the two that are missing names.

[oslo (wessel-roos-gmail)]

Hello list ;)

I am experiencing the same problem. If special characters are used in the track names, SoundJuicer just quits. Ofcourse, this can be solved by marking the option "strip special characters" but then all the characters (including spaces) are transformed into underscores_

Using Ubuntu 7.10 herd 3

When "extract" is pressed the following happens:
1. an empty pop up with only the button 'close' appears
2. when close is pressed, a new pop up appears saying: "Sound Juicer could not extract this CD. Reason: error starting ripping pipeline"

If "Strip special characters" is used, everything works as expected. (The only thing is that you will be editing all the song names by hand..)

If you need some more info, I'd be happy to help out.

Regards,

Oslo

[Pedro Villavicencio (pedro)]

fixed upstream, thanks.

[Launchpad Janitor (janitor)]

This bug was fixed in the package sound-juicer - 2.21.1-0ubuntu1

---------------
sound-juicer (2.21.1-0ubuntu1) hardy; urgency=low

  * New upstream release
    - Save custom genres (LP: #132402)
    - Make the progress bar smaller
    - Detect VFAT and NTFS filesystems and strip characters they can't handle
      (LP: #72218), (LP: #137359)
    - Inhibit power management suspension when ripping
    - Don't crash when finished extracting
    - Remove the Rip Completed dialog
    - Set pipeline state to NULL when disposing
    - Escape the album and artist in the cluebar
  * Bump Standards-Version to 3.7.3
  * Updated debian/patches
  * debian/control{.in} add Dep to libcdio-dev to get track names from CD-TEXT (LP: #106391)

 -- Pedro Fragoso <email address hidden> Fri, 04 Jan 2008 04:30:31 +0000