The GTK_STOCK_DIRECTORY icon isn't being themed

[Carthik Sharma]

Originally filed using reportbug. Filing here by proxy.

From: Rimas Kudelis <email address hidden>
To: Ubuntu Bug Tracking System <email address hidden>
Subject: ubuntu-artwork: The GTK_STOCK_DIRECTORY icon isn't being themed
Message-ID: <email address hidden>
X-Mailer: reportbug 3.18ubuntu1
Date: Sun, 30 Jul 2006 17:55:37 +0300
X-Virus-Scanned: amavisd-new at takas.lt

Package: ubuntu-artwork
Version: 28
Severity: normal

I noticed that applications using GTK_STOCK_DIRECTORY stock icon are still getting
the icon from "gnome" theme (seems to be
/usr/share/icons/gnome/24x24/stock/io/stock_open.png).

It would be great if this problem was fixed, as icons for replacement are already
available, you just have to symlink/describe them properly.

-- System Information:
Debian Release: testing/unstable
  APT prefers dapper-updates
  APT policy: (500, 'dapper-updates'), (500, 'dapper-security'), (500,
'dapper-backports'), (500, 'dapper')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-26-686
Locale: LANG=lt_LT.UTF-8, LC_CTYPE=lt_LT.UTF-8 (charmap=UTF-8)

Versions of packages ubuntu-artwork depends on:
ii gtk2-engines-ubuntulooks 0.9.11-1 'ubuntulooks' theme for GTK+ 2.x

ubuntu-artwork recommends no packages.

-- no debconf information

[Daniel Holbach (dholbach)]

Thanks for your bug report. What do you mean by GTK_STOCK_DIRECTORY? ubuntu-artwork (or human-icon-theme as it is called in Edgy) never set out to invent replacements for every single stock icon. http://daniel.holba.ch/ubuntu/ic might give you a bit of an overview.

[Rimas Kudelis (rq)]

@Carthic:
thanks for proxying my bugreport. I couldn't manage to report it here for some reason (malone said the ubuntu-artwork package didn't use malone). Hence, i used reportbug... :)

@Daniel:
By GTK_STOCK_DIRECTORY i mean this item:
http://developer.gnome.org/doc/API/2.0/gtk/gtk-Stock-Items.html#GTK-STOCK-DIRECTORY:CAPS

While most of the other stock GTK icons are altered by Human theme, this one isn't. And considering, that you already do have a suitable item for this use (folder-open), and the default gorilla'ish one just doesn't fit in the context of orange folders, I think this should be addressed. A simple symlink or an edit of the theme xml file would do, IMHO.

I'm not sure, but I think this icon is being used in Rhythmbox (File > Open folder). Also, this icon is being used in some places in LinuxDC++ client.

[Rimas Kudelis (rq)]

While in Gnome theme the stock_open icon is in /stock/io/, and the context for this directory is set to "Stock", in Human the same icon is put to /status/, for which the context is set to "Status". Maybe this is the cause of this problem?

[Daniel Holbach (dholbach)]

Human icon theme uses the new Icon Naming specification and gnome icon theme will use it for GNOME 2.16 as well. I'm inclined to close this bug or do I miss something?

http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

[Rimas Kudelis (rq)]

This is a GTK icon, not GNOME icon. Does what you said about GNOME 2.16 affect GTK too?

[Rimas Kudelis (rq)]

Ouch, sorry for reattaching the bug to ubuntu-artwork...

[Rimas Kudelis (rq)]

I still have the same problem in Edgy - GTK_STOCK_DIRECTORY icon in applications doesn't change when I apply Human theme.

People even started workarounding this in their software: http://bugzilla.gnome.org/show_bug.cgi?id=354575

[Rimas Kudelis (rq)]

I have filed this problem as a GTK+ bug on their bugzilla:
http://bugzilla.gnome.org/show_bug.cgi?id=356270

[Daniel Holbach (dholbach)]

How can we go about fixing the problem?

[Rimas Kudelis (rq)]

I don't actually know. The icon that is used for GTK_STOCK_DIRECTORY is no longer in /usr/share/icons/gnome/24x24/stock/io/stock_open.png. I don't understand where GTK picks it from.

However, making a following symlink:
/usr/share/icons/Human/24x24/actions/gtk-directory.png -> ../status/folder-open.png
makes GTK pick a nice orange icon for a folder. This could work as a solution for now, as long as GTK does not yet support FD specs.

[Rimas Kudelis (rq)]

uh... disregard the first paragraph in my previous message. I wrote it before finding the solution...

[Jason Gerard DeRose (jderose)]

The status of this bug should really be set to high or critical, as Human should be considered broken by this. That Human didn't set out to replace every stock icon is not a good excuse, and this is why:

1) STOCK_OPEN and STOCK_DIRECTORY are very similar on the one hand, and often both will be used in the same application, so they should look similar.

2) On the other hand, they are *not* interchangeable semantically. If an application has a button that opens a folder, it will use STOCK_DIRECTORY. If an application has a button that opens a file, it will use STOCK_OPEN. This lack of interchangeability is especially true in the case of a gtk.Button(stock=STOCK_WHATEVER), where the application is also utilizing the internationalized text associated with the stock item.

In this second case, something is really broken, as this screenshot shows.

icon.set_from_stock() is at least working, despite not loading an icon that matches the theme.

[Jason Gerard DeRose (jderose)]

Here is a simple Python test script that demonstrates the problem, from which the screenshot was taken.

[Rimas Kudelis (rq)]

By the way, only 24x24 icon is not enough, you need to take care of the other sizes aswell (e.g. menu uses 16x16 by default, I guess). We need at least 16x16, 22x22, and 24x24 icons.

[Troy James Sobotka (troy-sobotka)]

So we have a viable method around this, is this still relevant Daniel? Can we symlink it and close this bug?

[Daniel Holbach (dholbach)]

I wonder why icon-naming-utils don't take care of that.

Would
  actions/gtk-directory.png -> status/folder-open.png
resolve the issue?

[Rimas Kudelis (rq)]

I think it would. However, you can also run Jason's test script to check if things are fixed.

[Daniel Holbach (dholbach)]

After Herd2:

 icon-naming-utils (0.8.1-1ubuntu2) feisty; urgency=low
 .
   * debian/patches/04_add_gtk_stock_directory.patch:
     - actions/gtk-directory.png -> status/folder-open.png

 human-icon-theme (0.8-0ubuntu2) feisty; urgency=low
 .
   * debian/control:
     - Rebuild with newest icon-naming-utils. (Malone: #54890)