documentation needs updating
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
display-dhammapada |
In Progress
|
Undecided
|
bodhi.zazen | ||
display-dhammapada (Debian) |
Fix Released
|
Unknown
|
|||
display-dhammapada (Ubuntu) |
Fix Released
|
Undecided
|
bodhi.zazen |
Bug Description
I just finished packaging display-dhammapada for Fedora and so went through this package.
1. The man page needs updating as it contains undefined macros and dead links / url.
see below for patchs
patch display-
patch display-
2. When reviewing the package, the Makefile appears to be intended to be run as root. This is sort of outdated as most packaging is done as users using fakeroot. I had to patch the Makefile for Fedora, you may wish to review this in the .deb
If you wish, I can attach my Makefile as a patch, but, rmp packaging is different from deb, so much of it is defined in the (rpm) .spec
What you will want to look at is
a. Packaging as a user, not root.
b. Ownership and permissions of files.
c. The c-flags. You may or may not wish to update the cflags.
d. The path (see #3) for files.
3. You may wish to review the locations of the display-dhammapada .txt files. By default , /usr/lib and /usr/local/lib are used. I am not sure if either are appropriate, so I moved it to /usr/share
in display-
See patch display-
4. I think the file examples/xsession should start with a shee-bang
#! /bin/sh
I will report this on Debian as well, not sure how active upstream (from Debian) is ...
Related branches
description: | updated |
Changed in display-dhammapada (Debian): | |
status: | Unknown → New |
Changed in display-dhammapada (Ubuntu): | |
status: | New → In Progress |
Changed in display-dhammapada: | |
status: | New → In Progress |
Changed in display-dhammapada (Debian): | |
status: | New → Fix Released |
The attachment "patch display- dhammapada. 1" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.
[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]