when creating a partition of type fat, don't specify label
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
diskimage-builder |
Fix Released
|
Undecided
|
Amrith Kumar |
Bug Description
When making an ext[234] partition, you can specify a volume label on the command line to mkfs with the -L option. This is however not a part of the options of mkfs; only of mke2fs [see man 8 mke2fs].
mkfs.fat provides no such thing [see man 8 mkfs.fat]
As a result, when creating a partition of type fat, I get the following failure in dib (see attach.txt, attached).
Here's the quick test of the failing command
$ sudo mkfs -t fat -L mkfs_boot /dev/mapper/loop0p5
mkfs.fat 3.0.28 (2015-05-16)
mkfs.fat: invalid option -- 'L'
Unknown option: ?
Usage: mkfs.fat [-a][-A]
[-m boot-msg-file][-n volume-name][-i volume-id]
[-s sectors-
[-h hidden-sectors][-F fat-size][-r root-dir-
[-M FAT-media-byte][-D drive_number]
[--help]
/dev/name [blocks]
the correct option for fat and vfat is -n, the fix is trivial, I'll push it up shortly.