DIB_IMAGE_ROOT_FS_UUID removed but still referenced in iso element and docs

Bug #1699273 reported by Mark Goddard
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
diskimage-builder
Fix Released
Undecided
Ettore Simone

Bug Description

As part of [1], the variable DIB_IMAGE_ROOT_FS_UUID was removed. However, this variable is still referenced within the DIB codebase:

$ grep -rn DIB_IMAGE_ROOT_FS_UUID
doc/source/developer/developing_elements.rst:257:``DIB_IMAGE_ROOT_FS_UUID``
diskimage_builder/elements/iso/cleanup.d/100-build-iso:164: EMITTED_KERNEL_CMDLINE_ARGS="root=UUID=$DIB_IMAGE_ROOT_FS_UUID"

Also, the variable is currently referenced by the fedora-atomic element[2] owned by the magnum project and its removal causes the fedora-atomic element to fail to build.

[1] https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=e4e23897a13a3f3b9d28cc8d288990ab0fcc5b92
[2] https://github.com/openstack/magnum/blob/907415c984e95e09a8b872f3c551ae6108c91de1/magnum/drivers/common/image/fedora-atomic/finalise.d/80-fedora-atomic#L30

Revision history for this message
Mark Goddard (mgoddard) wrote :

Related bug in magnum: 1699735

Ettore Simone (esimone)
Changed in diskimage-builder:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to diskimage-builder (master)
Changed in diskimage-builder:
status: Confirmed → In Progress
Ettore Simone (esimone)
Changed in diskimage-builder:
assignee: nobody → Ettore Simone (esimone)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to diskimage-builder (master)

Reviewed: https://review.opendev.org/c/openstack/diskimage-builder/+/905556
Committed: https://opendev.org/openstack/diskimage-builder/commit/741ab26206000c4bb4987f0b5cfdce583049f065
Submitter: "Zuul (22348)"
Branch: master

commit 741ab26206000c4bb4987f0b5cfdce583049f065
Author: Ettore Simone <email address hidden>
Date: Sun Jan 14 11:40:38 2024 +0100

    Cleanup uses of DIB_IMAGE_ROOT_FS_UUID variable

    Since 2.4.0 disk-image-create does not export DIB_IMAGE_ROOT_FS_UUID
    anymore. This patch fix documentation and the iso element.

    Closes-Bug: 1699273
    Change-Id: I5e926c36256e580579bfd2c5aeff4ba6193c367a

Changed in diskimage-builder:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.