Bug #1627000 “DIB fails to build RHEL image” : Bugs : diskimage-builder

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-23: Fix proposed to diskimage-builder (master)

#1

Fix proposed to branch: master
Review: https://review.openstack.org/375430

Changed in diskimage-builder:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-12: Fix merged to diskimage-builder (master)

#2

Reviewed: https://review.openstack.org/375430
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=93425d14ce251139e0518a3a9533506dd1615f97
Submitter: Jenkins
Branch: master

commit 93425d14ce251139e0518a3a9533506dd1615f97
Author: Jiri Stransky <email address hidden>
Date: Fri Sep 23 14:09:02 2016 +0200

Fix grub installation for RHEL

    Grub is first removed and then installed during RHEL image building. The
    grub2 package typically requires the same version of grub2-tools, so if
    we just remove and install the grub2 package, the installation can
    potentially fail on being out of sync with grub2-tools version. Removing
    and reinstalling both packages fixes this issue. Those packages are
    already in package map for RHEL as "grub-pc", so we can use this alias.

Change-Id: Iefd9c17fffd43de3fea260510ad218b1322eecb3
Closes-Bug: #1627000

Changed in diskimage-builder:
status:	In Progress → Fix Released

Revision history for this message

Ian Wienand (iwienand) wrote on 2016-10-19:

#3

I can't seem to reopen this, but I've had to propose a revert of this with https://review.openstack.org/388468 because it's going to break fedora & centos builds

Looking more closely, I think the above solution is wrong. grub2-tools should have been installed by the package-map.yaml file. Thus we should only need to install the grub2 package at final time.

I get the feeling that this is instack and maybe it's not doing the package-map installs? I think we'll need more logs to debug this further

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-19: Related fix proposed to diskimage-builder (master)

#4

Related fix proposed to branch: master
Review: https://review.openstack.org/388567

Revision history for this message

Jiří Stránský (jistr) wrote on 2016-10-19:

#5

The revert would break RHEL again, i explained at https://review.openstack.org/388468 why. If possible we should try to fix this in a way that will make all distros build fine so that we don't just oscillate between different kinds of breakages.

Based on your description of the failure (rpm failing because the package is already installed) i proposed an alternative to the revert here https://review.openstack.org/388567/ Hopefully that could fix it?

Stephane Miller (stephaneeee) on 2016-10-19

Changed in diskimage-builder:
status:	Fix Released → New

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-31: Fix proposed to diskimage-builder (feature/v2)

#6

Fix proposed to branch: feature/v2
Review: https://review.openstack.org/391939

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-01: Change abandoned on diskimage-builder (master)

#7

Change abandoned by Jiri Stransky (<email address hidden>) on branch: master
Review: https://review.openstack.org/388567
Reason: We went with Iafe3611f4eec3c6357587a6cae6a30a261686ead

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-01: Related fix merged to diskimage-builder (master)

#8

Reviewed: https://review.openstack.org/388580
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=e531980a14d55ecf437188fb92fc332a82c2d537
Submitter: Jenkins
Branch: master

commit e531980a14d55ecf437188fb92fc332a82c2d537
Author: Ian Wienand <email address hidden>
Date: Wed Oct 19 09:34:54 2016 +0000

Remove RedHat grub workaround install

AFAICT this is no longer necessary. I've tested minimal and image
builds and they seem to work.

    The original problem seems to be with installing the package in the
    chroot, although it was never quite clear it ever affected the Red Hat
    path.

    This code is currently broken (see
    I884cb1e78ad8c31d985f3fc94a58091b993edd7d). This is proposed as an
    alternative to I74eed074494134334d5e49042bb5214bd0dd7339.

Related-Bug: #1627000

Change-Id: Iafe3611f4eec3c6357587a6cae6a30a261686ead

Gregory Haynes (greghaynes) on 2016-11-01

Changed in diskimage-builder:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-01: Fix merged to diskimage-builder (feature/v2)

#9

Download full text (16.0 KiB)

Reviewed: https://review.openstack.org/391939
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=7cc65d3cbdbffb4ac941dbb889f436be1d18cfa2
Submitter: Jenkins
Branch: feature/v2

commit 872da68a9032036d392e7b6236d730b7c17b7eb7
Author: Paul Belanger <email address hidden>
Date: Sun Oct 23 18:49:33 2016 -0400

Add support for bindep.txt

    Currently, this is a noop, since diskimage-builder currently uses
    tests/install_test_deps.sh to manage OS dependencies. The next patch
    in the series, will complete the migration to bindep.

Change-Id: I3b599983106b87fec6a4b6348469ed037654810e
Signed-off-by: Paul Belanger <email address hidden>

commit 7f1494a43348da65c0006c8d2477c6ab36bd5fb1
Author: Markos Chandras <email address hidden>
Date: Wed Oct 19 18:59:07 2016 +0100

elements: zypper: Do not pull recommended packages

    Recommended packages are usually useful but we normally don't need
    them in order to have a working system. As a result, avoid pulling
    them in when doing a regular package installation or a distribution
    update. Extra packages can be pulled in using the usual '-p' parameter
    or from within the elements that actually need them. The results of
    this change are quite significant, resulting to gains from a few dozen
    of MBs up to a few hundred depending on the selected elements.

Change-Id: I5838829c631990c7a1f3b67548accd9a603fe20c

commit a44b55ccaaff7f252f048a180a26006c86d21ceb
Author: Ian Wienand <email address hidden>
Date: Thu Oct 20 15:19:31 2016 +1100

Turn down yum install-packages

When debugging, this is very noisy for very little value. If we need
to specifically debug this script we can turn up the level.

Change-Id: Ie15f16397c37e718aa919853697cbf2c5c08503c

commit cfcbd4ffbefe4d5bc2bd78b510a3eb1f619af377
Author: Markos Chandras <email address hidden>
Date: Wed Oct 19 17:53:01 2016 +0100

elements: source-repositories: Add git package mapping for SUSE

The 'git' command line tool is in the git-core SUSE package

Change-Id: Ib2c5dc5ab9bbde2520f43682c654a9c3270bac09

commit 1fe1e3f606aacabad8de78d36c0ba1f91962bc9e
Author: Markos Chandras <email address hidden>
Date: Wed Oct 19 16:16:35 2016 +0100

elements: growroot: Add SUSE package mappings

Add growpart and e2fsprogs package mappings for SUSE.

Change-Id: I4544c3b5bd561f7483cd10f65e2d6366b52d57cd

commit bb29082910b822aae2c27cdf39c67545e3f326f9
Author: Matthew Thode <email address hidden>
Date: Tue Oct 11 20:17:49 2016 -0500

Document install of diskimage-builder on Gentoo

Change-Id: I27bf3499f998dcbdeb5cfebddde306e5200cc0b5

commit 82b299bbdfb4df55c44b1526491be64cdf89e181
Author: Matthew Thode <email address hidden>
Date: Fri Oct 7 11:16:28 2016 -0500

start cloud-init-local in the boot runlevel

    cloud-init-local needs to be run in the boot runlevel because it
    modifies services in the default runlevel. When a runlevel is started
    it is cached, so modifications that happen to the current runlevel while
    you are in it are not acted upon.

Change-Id: Ifeae0071fc9e738ec223ec0...

Reviewed:  https://review.openstack.org/391939
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=7cc65d3cbdbffb4ac941dbb889f436be1d18cfa2
Submitter: Jenkins
Branch:    feature/v2

commit 872da68a9032036d392e7b6236d730b7c17b7eb7
Author: Paul Belanger <pabelanger@redhat.com>
Date:   Sun Oct 23 18:49:33 2016 -0400

Add support for bindep.txt
    
    Currently, this is a noop, since diskimage-builder currently uses
    tests/install_test_deps.sh to manage OS dependencies. The next patch
    in the series, will complete the migration to bindep.
    
    Change-Id: I3b599983106b87fec6a4b6348469ed037654810e
    Signed-off-by: Paul Belanger <pabelanger@redhat.com>

commit 7f1494a43348da65c0006c8d2477c6ab36bd5fb1
Author: Markos Chandras <mchandras@suse.de>
Date:   Wed Oct 19 18:59:07 2016 +0100

elements: zypper: Do not pull recommended packages
    
    Recommended packages are usually useful but we normally don't need
    them in order to have a working system. As a result, avoid pulling
    them in when doing a regular package installation or a distribution
    update. Extra packages can be pulled in using the usual '-p' parameter
    or from within the elements that actually need them. The results of
    this change are quite significant, resulting to gains from a few dozen
    of MBs up to a few hundred depending on the selected elements.
    
    Change-Id: I5838829c631990c7a1f3b67548accd9a603fe20c

commit a44b55ccaaff7f252f048a180a26006c86d21ceb
Author: Ian Wienand <iwienand@redhat.com>
Date:   Thu Oct 20 15:19:31 2016 +1100

Turn down yum install-packages
    
    When debugging, this is very noisy for very little value.  If we need
    to specifically debug this script we can turn up the level.
    
    Change-Id: Ie15f16397c37e718aa919853697cbf2c5c08503c

commit cfcbd4ffbefe4d5bc2bd78b510a3eb1f619af377
Author: Markos Chandras <mchandras@suse.de>
Date:   Wed Oct 19 17:53:01 2016 +0100

elements: source-repositories: Add git package mapping for SUSE
    
    The 'git' command line tool is in the git-core SUSE package
    
    Change-Id: Ib2c5dc5ab9bbde2520f43682c654a9c3270bac09

commit 1fe1e3f606aacabad8de78d36c0ba1f91962bc9e
Author: Markos Chandras <mchandras@suse.de>
Date:   Wed Oct 19 16:16:35 2016 +0100

elements: growroot: Add SUSE package mappings
    
    Add growpart and e2fsprogs package mappings for SUSE.
    
    Change-Id: I4544c3b5bd561f7483cd10f65e2d6366b52d57cd

commit bb29082910b822aae2c27cdf39c67545e3f326f9
Author: Matthew Thode <mthode@mthode.org>
Date:   Tue Oct 11 20:17:49 2016 -0500

Document install of diskimage-builder on Gentoo
    
    Change-Id: I27bf3499f998dcbdeb5cfebddde306e5200cc0b5

commit 82b299bbdfb4df55c44b1526491be64cdf89e181
Author: Matthew Thode <mthode@mthode.org>
Date:   Fri Oct 7 11:16:28 2016 -0500

start cloud-init-local in the boot runlevel
    
    cloud-init-local needs to be run in the boot runlevel because it
    modifies services in the default runlevel. When a runlevel is started
    it is cached, so modifications that happen to the current runlevel while
    you are in it are not acted upon.
    
    Change-Id: Ifeae0071fc9e738ec223ec0df271559ad6e0196b

commit 7f9506962a394769b4459c07c482e073674309d3
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Thu Oct 6 14:04:42 2016 -0700

Fix formatting for supported distros in docs
    
    The supported distros table is not formatted consistently.
    
    Change-Id: Ic9e32786419243c118088f933d86329480f3345b

commit 5758176a4237c91aa60503175d8aebd8749f7c83
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Thu Oct 6 14:01:18 2016 -0700

Rename devloper documentation to developer guide
    
    We currently have 'user guide' and 'developer documentation'. Lets
    rename to 'developer guide' for consistency.
    
    Change-Id: I834ea313bc34275ef33e8c49a1689dff41892015

commit 9f3bb9652a3bbae407814cda717e962f3242c68f
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Thu Oct 6 13:58:28 2016 -0700

Remove copyright from docs / toc
    
    This is redundant (we have these copyright notices elsewhere) and
    provide no value to the user.
    
    Change-Id: I3699c01f0d4126cdffb3e3edf87ce62325f9f67a

commit 14b9d7ff3e634c3d7b5d5164d8a29414a74ccc77
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Thu Oct 6 13:54:28 2016 -0700

Use globaltoc in docs for sidebar
    
    By default sphinx uses localtoc which means 'show TOC for this page'.
    Using a global table of contents on the sidebar is much more user
    friendly wih our docs structure.
    
    Change-Id: I215732d3848b4b75d9171bdbaaf2ff2e4dcc01f0

commit c80cf9ec583ab734417de142b4be05cbd8500bf4
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Thu Oct 6 13:47:21 2016 -0700

Fix developer guide TOC
    
    The table of contents for our developer guide does not show due to the
    fact that it is past the first sub-header.
    
    Change-Id: I8459a4949e3e4822b0a3cd4f163475d2c60b0f2e

commit 3e4889cd6af380b25b94801dc0486a27fd6352f4
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Thu Oct 6 14:50:46 2016 -0700

Add low-hanging-fruit bug tag to docs
    
    This is useful in the developer quickstart guide.
    
    Change-Id: I54e7166bace055ae583f5dc84b648bba5f4f9cf4

commit 9a8d67e36f305e9e966e715b4b4905ee078b101a
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Thu Oct 6 14:49:08 2016 -0700

Add bugs link to docs
    
    Change-Id: I09dcfe5abbc76e1383851282f063f4c338f6d93a

commit a74b5fe399c4955015fb9dac0ca5257abf4a1415
Author: Andreas Jaeger <aj@suse.com>
Date:   Thu Oct 6 20:26:07 2016 +0200

Enable release notes translation
    
    Releasenote translation publishing is being prepared. 'locale_dirs'
    needs to be defined in conf.py to generate translated version of the
    release notes.
    
    Note that this repository might not get translated release notes - or
    no translations at all - but we add the entry here nevertheless to
    prepare for it.
    
    Change-Id: Ib3cfb6a2cc014b72c32db7434975d4bb75d480d7

commit 3571647692558c29cb26f1b20e1fa908477b6a7e
Author: Matthew Thode <mthode@mthode.org>
Date:   Thu Oct 6 11:57:34 2016 -0500

Add pkg-map for gentoo to runtime-ssh-host-keys
    
    Openssh is provided by default so it is not needed to be installed here.
    
    Change-Id: Id86f9a1d214c775570f0c9e2df4ea81367bb5b7e

commit 2ea5feca5c4b64867ac327736edfb20408f8840e
Author: Paul Belanger <pabelanger@redhat.com>
Date:   Fri Sep 30 15:59:46 2016 -0400

Create (md5|sha256) checksum files for images
    
    In shade, we use both md5 and sha256 checksums to help validate the
    integrity of an image. Rather then having nodepool do this each time
    for every time, have diskimage-builder create these files when we
    build the image.
    
    We've added a flag (disabled by default) to toggle this functionality.
    
    Change-Id: I5815ba69b7d477f1e91dc8ec0c69c86168770964
    Signed-off-by: Paul Belanger <pabelanger@redhat.com>

commit 90536dbab3e425d71a626f534307304389a2b7fd
Author: Markos Chandras <mchandras@suse.de>
Date:   Mon Oct 3 15:51:18 2016 +0100

Add opensuse-minimal element
    
    Add a new opensuse-minimal element to build small and highly
    configurable openSUSE based images using the zypper-minimal element
    as the main building mechanism
    
    Change-Id: Iebfc4ad4aff763e511b093f1607b55851ccbddcb

commit c69c6c5a84da59bf3f7d6b8e79063d70d0ff4fe6
Author: Markos Chandras <mchandras@suse.de>
Date:   Fri Sep 30 11:13:09 2016 +0100

Add zypper-minimal element
    
    Add a new zypper-minimal element to bootstrap SUSE-based distributions
    
    Change-Id: Id63397e412a929d61247cfd3d9f8d4e758c1248a

commit 8dde310cf3a1b24696822fe2fd2850aee07ea3d6
Author: Markos Chandras <mchandras@suse.de>
Date:   Fri Sep 30 12:06:09 2016 +0100

Move the opensuse mkinitrd script to the zypper element
    
    All SUSE-based elements can benefit from the mkinitrd phase to move it
    to a more generic location.
    
    Change-Id: Ife171d462a393b6ac0bf2c5eaa48ea25eaf4d1cc

commit 30b3fc8dcc810725819f92c91ba68061f81229dc
Author: Hironori Shiina <shiina.hironori@jp.fujitsu.com>
Date:   Tue Oct 4 22:22:26 2016 +0900

Fix a command in Developer Documentation
    
    Fix a command for creating a new virtualenv.
    
    Change-Id: Ia4981af390bf5218f22ea753db86a5edfbb602f2

commit 7dc9465ed107368c300db99ae474b0ee5c84bcb9
Author: Paul Belanger <pabelanger@redhat.com>
Date:   Tue Sep 27 17:25:37 2016 -0400

Default to http://ftp.us.debian.org/debian for debian-minimal
    
    Since http://httpredir.debian.org is unreliable is selecting a mirror
    to use, we'll now default to http://ftp.us.debian.org/debian.  In
    fact, in openstack-infra we have been overriding httpredir.debian.org
    for a while, now make this default in diskimage-builder.
    
    Change-Id: I48658bc076e13a0913821197e4120c73618fef8f
    Signed-off-by: Paul Belanger <pabelanger@redhat.com>

commit 1f10f4fa3530eaebd9e8f0578da87796825e070d
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Fri Sep 30 19:58:01 2016 +0000

Updated from global requirements
    
    Change-Id: I0f152cb4160915bbcad273bca7d28f947b82eae4

commit b9e9e2091e42d03e377b2cc7e8e03e67a7ba60b6
Author: Markos Chandras <mchandras@suse.de>
Date:   Thu Sep 29 22:43:20 2016 +0100

Move opensuse utils to zypper so they can be shared by SUSE-based distros
    
    Move the opensuse utilities to the zypper element so they can be used by
    SUSE or zypper based elements. This brings the zypper element somewhat
    in line with the rest of the package manager elements.
    
    Change-Id: I8aa2849231454216cdd47629a5e2d6e45769dbbe

commit c6b4e639b02fc6d1a4b0cc54152361b6e3034f75
Author: Yolanda Robla Mota <yroblamo@redhat.com>
Date:   Tue Sep 27 10:09:35 2016 +0200

Disabling all previous repos registered in the system
    
    Depending on the pool id used, so many repos are brought,
    including not valid ones that cause image to crash, or repos
    that include conflicting packages.
    Before enabling repos, disable all previous ones, so we
    can be sure that we only bring the repos specified in the
    parameters.
    
    Change-Id: Ifd4d8d1d4fa954cd2593669e516e3201f2d6f6c1

commit f6e11c91c30b7983142b676c700398b17eb760d5
Author: Yolanda Robla Mota <yroblamo@redhat.com>
Date:   Tue Sep 27 09:41:32 2016 +0200

Fix typo in extracting root partition
    
    Change-Id: Ie8dfd958d57ef92988647166f2031adb8406b0d7

commit 45467e4229b6222c63a1d274331c6fe81bca8442
Author: Paul Belanger <pabelanger@redhat.com>
Date:   Wed Sep 21 16:02:16 2016 -0400

Create runtime-ssh-host-keys element
    
    Move managing of SSH host keys into a dedicated element.
    
    Because glean doesn't generate SSH host keys anymore, we need to do it
    with a systemd script. This is already handled by CentOS / Fedora so
    we don't want to add it there.
    
    This was done to address the upstream bug in debian:
    
      https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=500192
    
    Change-Id: I31ad667672e08350872db21a83445fe0aa7a4a39
    Signed-off-by: Paul Belanger <pabelanger@redhat.com>

commit 93425d14ce251139e0518a3a9533506dd1615f97
Author: Jiri Stransky <jistr@redhat.com>
Date:   Fri Sep 23 14:09:02 2016 +0200

Fix grub installation for RHEL
    
    Grub is first removed and then installed during RHEL image building. The
    grub2 package typically requires the same version of grub2-tools, so if
    we just remove and install the grub2 package, the installation can
    potentially fail on being out of sync with grub2-tools version. Removing
    and reinstalling both packages fixes this issue. Those packages are
    already in package map for RHEL as "grub-pc", so we can use this alias.
    
    Change-Id: Iefd9c17fffd43de3fea260510ad218b1322eecb3
    Closes-Bug: #1627000

commit 2747613ca2fc51118526f4ad6e28ed7b49e50632
Author: Ben Nemec <bnemec@redhat.com>
Date:   Thu Sep 22 14:25:31 2016 -0500

Shorten DHCP timeout in dhcp-all-interfaces
    
    We are currently wasting about 10 minutes per deploy waiting for
    DHCP on interfaces that will never get it.  By default, the timeout
    seems to be 5 minutes (the 10 minutes is because we boot both the
    IPA ramdisk and the deployed image, and each waits for 5 minutes),
    which is excessively long to get a DHCP response.  This change
    shortens the time to 30 seconds.  If an interface hasn't gotten a
    response in 30 seconds, chances are it's not going to.  A 30
    second wait should reduce our wasted time to 1 minute, which is
    more reasonable.
    
    This is being done in the systemd unit file because the -timeout
    option to dhclient doesn't seem to override what is configured in
    dhclient.conf, and doing it in the systemd file means that this
    change will be limited to only the interfaces configured by
    dhcp-all-interfaces.
    
    Change-Id: Ia8610e3def39c937eb0c861fdc9bc571ec39f9f4
    Closes-Bug: 1626673

commit 0ddea940adf0f80d8ff54c1c4289d3a0aa46d032
Author: Markos Chandras <mchandras@suse.de>
Date:   Fri Sep 16 11:04:56 2016 +0100

elements: opensuse: Add support for openSUSE Leap
    
    Add support for new openSUSE Leap releases. Moreover, document
    common environment variables and remove old note.
    
    Change-Id: I8cf0b215cb4d9231e5658d49e3fd598dfbb5fd37

commit bc80572061eb4c638e4c64d7d96fac39e6d79eab
Author: Waldemar Znoinski <waldemar.znoinski@intel.com>
Date:   Thu Sep 8 17:11:32 2016 +0000

don't configure 'lo' for dhcp
    
    On systemd-based operating systems that don't
    use /etc/sysconfig/network-scripts
    dhcp-all-interfaces configures 'lo' for dhcp.
    This causes errors and fails networking.target
    causing system-wide issues. This change excludes
    'lo' at dhcp-all-interfaces udev rules level.
    
    Closes-bug: #1621501
    Change-Id: I7563b766827bedbea7ae1de35e5bdfcbf1fc0d1e
    Co-Authored-By: Jeremy Stanley <fungi@yuggoth.org>

commit 20bb6a02551d1608e8e1b7a5a51cbc8aeac2284a
Author: Andreas Florath <andreas@florath.net>
Date:   Wed Jul 20 23:34:50 2016 +0200

Add option to be able to run_functests.sh in parallel
    
    Running the functional tests is time consuming.  This patch adds the
    option `-j <job count>` to the tests/run_functests.sh: when given the
    test run in parallel up the <job count> jobs.
    When using this, be sure to have enough resources (CPUs, RAM and HD
    space) on the host.
    
    In addition there was the need to change two things:
    o Global /tmp/dib-test-should-fail was move to temporary build
      directory of each execution.
    o Because the logs might now interleave, each log line has now a
      prefix of the name of the testcase.
    
    [In my environment running functests sequential takes 15+ minutes,
    running them parallel takes less than 6 minutes.]
    
    Change-Id: Id9ea5131f0026c292ca6453ba2c80fe12c47f808
    Signed-off-by: Andreas Florath <andreas@florath.net>

commit 07f22a338861485a610db65d0d3a47df421414a7
Author: Clark Boylan <clark.boylan@gmail.com>
Date:   Thu Sep 1 14:46:03 2016 -0700

Document source glean installs in simple-init
    
    It is possible and often desired to install glean from a source
    repository when using the simple-init element. Document the process for
    doing this.
    
    Change-Id: Ie7c690406b14aae07d73261879b7ce8a2ed9dd8d

commit 6180d82f1431b8b0c9348de6cd2ee3b14ff4cc9e
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Fri Aug 19 16:04:32 2016 +0000

Allow ramdisk-create to run without $USER set
    
    It's possible this is run form an environment where $USER isn't set,
    properly fallback to whoami in this case.
    
    Change-Id: I1181f714c3c456ee264b34d282bac5c0adb67a0e

commit 48daefb685a67ca8734307df738401c3d14edd02
Author: Ian Wienand <iwienand@redhat.com>
Date:   Thu Aug 18 15:26:30 2016 +1000

Use temp file for du calculations
    
    Storing the du output in a variable seemed convenient, but I didn't
    realise just how big it could get especially with things like infra
    images -- there's something like 100MiB of text being stored in a bash
    variable here.
    
    Convert this to work with a temporary file
    
    Change-Id: I6a6d22c2142e0f199490c39cca8c94769e4b0232

tags:

added: in-feature-v2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-18: Related fix proposed to diskimage-builder (feature/v2)

#10

Related fix proposed to branch: feature/v2
Review: https://review.openstack.org/399347

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-18: Related fix merged to diskimage-builder (feature/v2)

#11

Download full text (14.6 KiB)

Reviewed: https://review.openstack.org/399347
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=7d5afecfd9e2ea5249ea7f12eba74c77c1abd7e6
Submitter: Jenkins
Branch: feature/v2

commit 8d7362aa9b4a9d2430de7959d4ee4c78429464c0
Author: d.marlin <email address hidden>
Date: Thu Nov 17 03:36:54 2016 -0500

Change path for dnf arch override so basearch is not overwritten.

    After writing the basearch value to /etc/dnf/vars/basearch the
    arch value was overwriting the same file. This appears to be
    incorrect, so changing it to write /etc/dnf/vars/arch, which
    matches the subsequent 'yum' code paths.

Change-Id: I5da54f03224c11f9e286f16b68533936c4174c2a

commit fb8cf95b6fb0820867ebfd262c38d2cae5ab43fa
Author: Ben Nemec <email address hidden>
Date: Wed Nov 16 16:27:24 2016 -0600

Disable all repos in os-refresh-config too

    This change was made for pre-install so it applies during the
    image build, but wasn't applied to the os-refresh-config script
    that would run after deployment. The same problems apply there,
    so we should do the same thing.

Change-Id: I4b8534cc9586eeb588b5c358550e76e27d40556a
Closes-Bug: 1629922

commit a1f57b8cad0717090eb12014d7847a35bd0563a3
Author: Markos Chandras <email address hidden>
Date: Mon Oct 31 21:43:47 2016 +0000

lib: common-functions: Fix tmpfs umounting

    It has been observed that some chroot operations spawn additional
    processes which rely on chroot files. More specifically, zypper, uses
    gpg-agent to import and validate gpg keys for its repositories. This
    gpg-agent process may stay alive for longer which prevents unmounting of
    the tmpfs directory since the gpg-agent process still uses libraries etc
    which were present in the chroot. We try to solve this by using walking
    all the pids in /proc to find out the running processes in the chroot and
    kill them gracefully. If that fails for whatever reason, then we simply
    keep trying to umount the tmpfs directory before we give up.

    The gpg-agent process usually terminates soon after its home directory
    disappears but on fast systems we can reach the 'umount tmpfs' point
    before gpg-agent terminates by itself. The solution is generic enough so
    other 'chroot processes' can also be handled appropriately.

Change-Id: Iccf332678c79266113e76f062884fc5ee79e515d

commit e88d6b37df5a210ad15da24403274914f737956e
Author: Noam Angel <email address hidden>
Date: Mon Oct 31 11:54:58 2016 +0200

add support for SUSE in dhcp-all-interfaces

    This patch will add support for SUSE network scripts,
    network script in SUSE saved under "/etc/sysconfig/network/ifcfg-*"
    see: https://www.suse.com/documentation/sled11/book_sle_admin/data/sec_basicnet_manconf.html

Change-Id: I87ac2e327cee4945c15da9f2e4adc0a8b7650712

commit d07d7ed15d54c37448d5be67c4e4707ba19edac0
Author: Noam Angel <email address hidden>
Date: Tue Nov 1 16:19:44 2016 +0200

simplify ARCH param for rhel/centos param can be x86_64 and amd64

for fedora/rhel/centos the main supported ARCH is x86_64. This patch allow
to call diskima...

Reviewed:  https://review.openstack.org/399347
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=7d5afecfd9e2ea5249ea7f12eba74c77c1abd7e6
Submitter: Jenkins
Branch:    feature/v2

commit 8d7362aa9b4a9d2430de7959d4ee4c78429464c0
Author: d.marlin <dmarlin@redhat.com>
Date:   Thu Nov 17 03:36:54 2016 -0500

Change path for dnf arch override so basearch is not overwritten.
    
    After writing the basearch value to /etc/dnf/vars/basearch the
    arch value was overwriting the same file.  This appears to be
    incorrect, so changing it to write /etc/dnf/vars/arch, which
    matches the subsequent 'yum' code paths.
    
    Change-Id: I5da54f03224c11f9e286f16b68533936c4174c2a

commit fb8cf95b6fb0820867ebfd262c38d2cae5ab43fa
Author: Ben Nemec <bnemec@redhat.com>
Date:   Wed Nov 16 16:27:24 2016 -0600

Disable all repos in os-refresh-config too
    
    This change was made for pre-install so it applies during the
    image build, but wasn't applied to the os-refresh-config script
    that would run after deployment.  The same problems apply there,
    so we should do the same thing.
    
    Change-Id: I4b8534cc9586eeb588b5c358550e76e27d40556a
    Closes-Bug: 1629922

commit a1f57b8cad0717090eb12014d7847a35bd0563a3
Author: Markos Chandras <mchandras@suse.de>
Date:   Mon Oct 31 21:43:47 2016 +0000

lib: common-functions: Fix tmpfs umounting
    
    It has been observed that some chroot operations spawn additional
    processes which rely on chroot files. More specifically, zypper, uses
    gpg-agent to import and validate gpg keys for its repositories. This
    gpg-agent process may stay alive for longer which prevents unmounting of
    the tmpfs directory since the gpg-agent process still uses libraries etc
    which were present in the chroot. We try to solve this by using walking
    all the pids in /proc to find out the running processes in the chroot and
    kill them gracefully. If that fails for whatever reason, then we simply
    keep trying to umount the tmpfs directory before we give up.
    
    The gpg-agent process usually terminates soon after its home directory
    disappears but on fast systems we can reach the 'umount tmpfs' point
    before gpg-agent terminates by itself. The solution is generic enough so
    other 'chroot processes' can also be handled appropriately.
    
    Change-Id: Iccf332678c79266113e76f062884fc5ee79e515d

commit e88d6b37df5a210ad15da24403274914f737956e
Author: Noam Angel <noama@mellanox.com>
Date:   Mon Oct 31 11:54:58 2016 +0200

add support for SUSE in dhcp-all-interfaces
    
    This patch will add support for SUSE network scripts,
    network script in SUSE saved under "/etc/sysconfig/network/ifcfg-*"
    see: https://www.suse.com/documentation/sled11/book_sle_admin/data/sec_basicnet_manconf.html
    
    Change-Id: I87ac2e327cee4945c15da9f2e4adc0a8b7650712

commit d07d7ed15d54c37448d5be67c4e4707ba19edac0
Author: Noam Angel <noama@mellanox.com>
Date:   Tue Nov 1 16:19:44 2016 +0200

simplify ARCH param for rhel/centos param can be x86_64 and amd64
    
    for fedora/rhel/centos the main supported ARCH is x86_64. This patch allow
    to call diskimage-builder with the above distro's with param ARCH=x86_64,
    And also retain same behaiver when call with ARCH=amd64 as it translate
    anyway to x86_64. Doing so wil simplify user expirience.
    
    Change-Id: I229e0912434109b1b48a030bd35ad8dc1096a629

commit 5d9d3d5cf0c7ab79a6cd32d43375fa683ae87609
Author: Saverio Proto <saverio.proto@switch.ch>
Date:   Mon Nov 14 15:32:08 2016 +0100

debian: install dialog package
    
    Without the dialog package is not possible
    to properly use an interactive frontend.
    
    debconf will print the following errors:
    
    debconf: unable to initialize frontend: Dialog
    debconf: (No usable dialog-like program is installed,
    so the dialog based frontend cannot be used. at
    /usr/share/perl5/Debconf/FrontEnd/Dialog.pm line 76, <> line 1.)
    
    Change-Id: I0c7142f717cacf7437dbac1e1696f39b00cb4c49

commit 79c27199f2ce11c579efa0cfce7ee2c3443ead89
Author: Ben Nemec <bnemec@redhat.com>
Date:   Fri Nov 11 14:30:21 2016 -0600

Install lsb package by map name instead of package name
    
    We have a pkg-map entry for lsb_release, but in package-installs.yaml
    we refer to the actual package name instead.  This will happen to
    work on Red Hat platforms, but it's actually wrong.
    
    Change-Id: Idb248f96e75fa1090422fa08e5fbb2385cc1f517

commit ae66b64c34ea4209e09adf804c8cd8446d7ae5db
Author: Oliver Walsh <owalsh@redhat.com>
Date:   Fri Nov 11 17:03:50 2016 +0000

In disk-image-create, append to INSTALL_PACKAGES instead of clobbering.
    
    This allows -p <packagelist> to be used multiple times.
    
    Change-Id: Iabe43982e1606c7ca963a1dd3b23ba47d148ae38
    Closes-Bug: #1641157

commit 7e60540c0d8d02c976f7890831e103584501c27c
Author: Ian Wienand <iwienand@redhat.com>
Date:   Thu Nov 10 14:22:17 2016 +1100

Cleanup yumdownloader repos
    
    yumdownloader has to have all the repo XML files, etc, which adds up
    to a not totally insignificant 150MiB or so.  Currently we're leaking
    this directory for every build, which adds up on regualar builders
    like nodepool.
    
    Isolate the call with a separate TMPDIR so we can clean it up after
    the initial download.
    
    Change-Id: Ic65e8ca837cc76b7a1bb9f83027b4a5bdd270f75

commit 0f742ce24a39706545333a2cad983bc0a7a11b9e
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Wed Nov 9 04:14:55 2016 +0000

Updated from global requirements
    
    Change-Id: I4b8e6f6fdf78706dbb735e25195a1f83413ab3fd

commit c7219a5a605e68f0ca46f4f1c130b602e25be073
Author: Luca Lorenzetto <lorenzetto.luca@gmail.com>
Date:   Mon Oct 10 16:00:16 2016 +0200

Avoid disabling rhel-7-server-rh-common-rpms
    
    while using disk-image-builder for building overcloud images for TripleO
    using RDO, this repository is (in my opinion) wrongly disabled because
    contains certain dependencies needed by RDO packages.
    Example: python-cheetah is required for python-nova, but is not
    available through RDO repository but only from
    rhel-7-server-rh-common-rpms
    
    Closes-Bug: #1638938
    Change-Id: I76824c8ec02590397f1ff1d4f177ad061c7bf441
    Signed-off-by: Luca Lorenzetto <lorenzetto.luca@gmail.com>

commit 435f52a7d1506b87d6b650adcdde35a36c242157
Author: Markos Chandras <mchandras@suse.de>
Date:   Wed Nov 2 22:05:05 2016 +0000

elements: zypper-minimal: Mount common pseudo filesystems
    
    Mount all the usual /dev /sys /proc pseudo filesystems during the
    root.d phase in order to make sure they are available for the rpm
    post-installation phases.
    
    Change-Id: I28221debf1036d9eb5137161757eb30811eafab1

commit bc66298937c55321874eb599aeddde25ce125dd3
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Wed Nov 2 15:31:00 2016 +0000

Updated from global requirements
    
    Change-Id: Ib41e9cf05743c05fb299f84516d9179ea41e3f46

commit d5225055ef2403b461083f5d76c67bc8410539a7
Author: Derek Higgins <derekh@redhat.com>
Date:   Wed Nov 2 11:01:15 2016 +0000

dhcp-all-interfaces: support Centos/RHEL 6
    
    On Centos and RHEL 6 the init system is upsart but but networking is using
    sysv compatabiliy and a code path the handle this situation.
    
    We can't use DISTRO_NAME because the centos-minimal element sets it to
    centos for CentOS 7 but the centos element sets it to centos for CentOS 6.
    
    Change-Id: Ib8e33ed78b3d6a5737eb7449bccef2d33f72b131
    Closes-Bug: #1638527

commit 290925bd5e0470f69357a8ff13e423ba628c49bb
Author: Markos Chandras <mchandras@suse.de>
Date:   Mon Oct 31 23:18:28 2016 +0000

elements: zypper-minimal: Refresh repositories after adding the cache
    
    The refresh operation must happen after the cache has been added in
    order to ensure that whatever is in the cache is still relevant to
    the current build and we are not using stale packages.
    
    Change-Id: Iafd718e9738f85b8c235806c027665730f44d89b

commit 348a6b337a18f4666ed99a387d20ed83c1aa86c8
Author: Markos Chandras <mchandras@suse.de>
Date:   Mon Oct 31 23:15:46 2016 +0000

elements: opensuse-minimal: Add support for building Tumbleweed images
    
    Add DIB_RELEASE=Tumbleweed option in order to build openSUSE Tumbleweed
    images
    
    Change-Id: I44cc04ef5a993c1a7f0078e4161888b52995f247

commit 2854f4063bd2a6dcdb6fa5fab93aa56857e47b59
Author: Bruno Cornec <bruno.cornec@hpe.com>
Date:   Fri Oct 28 19:38:50 2016 +0200

Fix ironic-python-agent image not loading vfat mod
    
    Closes-Bug: 1589450
    Load the vfat driver as a Pre Exec action for systemd before starting
    ironic-python-agent in order to allow reading of parameters.txt file
    required for the ironic-python-agent to find its configuration.
    
    Change-Id: Ibf74dd1b2678ea76e0676711a7aa5ba6b88d5421

commit 3b855faf5f5a27e2344f0185954f125e7baf931a
Author: nizam <abdul.nizamuddin@nectechnologies.in>
Date:   Fri Oct 28 19:51:55 2016 +0530

Don't include openstack/common in flake8 exclude list
    
    The directory openstack/common was used to keep codes from
    oslo-incubator, we have retired oslo-incubator, so don't use
    this directory any more
    
    Change-Id: Icd13d32674b117626fbecdfdec2881463a87ad5d

commit 51f982e3765705a619ec59671911163012265bea
Author: nizam <abdul.nizamuddin@nectechnologies.in>
Date:   Fri Oct 28 19:48:33 2016 +0530

Drop MANIFEST.in - it's not needed by pbr
    
    diskimage-builder already uses PBR:-
    setuptools.setup(
        setup_requires=['pbr>=1.8'],
        pbr=True)
    
    This patch removes `MANIFEST.in` file as pbr generates a
    sensible manifest from git files and some standard files
    and it removes the need for an explicit `MANIFEST.in` file.
    
    Change-Id: Iad8b724c1d1e0ef358606b13da4569d881ec740a

commit 4095046a25f94a06e44368f4f9726e9347f15e11
Author: nizam <abdul.nizamuddin@nectechnologies.in>
Date:   Fri Oct 28 19:46:02 2016 +0530

Changed the home-page of diskimage-builder in setup.cfg
    
    Instead of pointing to
    https://git.openstack.org/cgit/openstack/diskimage-builder, the
    homepage has been changed to point to the homepage of
    diskimage-builder.
    
    Change-Id: I795a5fd343ff7a06bfe43ae4a76dc24136db99a2

commit e531980a14d55ecf437188fb92fc332a82c2d537
Author: Ian Wienand <iwienand@redhat.com>
Date:   Wed Oct 19 09:34:54 2016 +0000

Remove RedHat grub workaround install
    
    AFAICT this is no longer necessary.  I've tested minimal and image
    builds and they seem to work.
    
    The original problem seems to be with installing the package in the
    chroot, although it was never quite clear it ever affected the Red Hat
    path.
    
    This code is currently broken (see
    I884cb1e78ad8c31d985f3fc94a58091b993edd7d).  This is proposed as an
    alternative to I74eed074494134334d5e49042bb5214bd0dd7339.
    
    Related-Bug: #1627000
    
    Change-Id: Iafe3611f4eec3c6357587a6cae6a30a261686ead

commit 6fb658a5f1bbc38baa07bb2f51acc6528b8c017a
Author: Ian Wienand <iwienand@redhat.com>
Date:   Mon Oct 24 11:17:28 2016 +1100

Don't log datestamp by default in functional tests
    
    We're getting double time-stamps in the console log of upstream jobs.
    Move the logging of a prefix datestamp into a "-t" option to retain
    the status quo prior to Id9ea5131f0026c292ca6453ba2c80fe12c47f808 (we
    could, of course, do it the other way and turn if off in the jobs, but
    since we didn't have it before...)
    
    While poking, make the time-stamp consistent and always prefixed if -t
    is turned on.
    
    Also, it seems the parallel options got a bit of sync with what got
    merged.  Add "-j" documentation and remove unused "p" option.
    
    Change-Id: Ic7c2ebeca3f9d5784cac59505b6e6181151f5805

commit 9e392f56b0b78f60bc2598c3cd99f8d7061cc550
Author: Ian Wienand <iwienand@redhat.com>
Date:   Thu Oct 20 13:51:16 2016 +1100

Don't set tracing in environment files
    
    Because environment files are sourced into the current environment,
    they shouldn't be setting global settings like tracing else they
    affect every preceeding import.  This is quite confusing when only
    half your imports are traced in the logs, because it was either turned
    on, or off, by a preceeding environment import.
    
    There is a corresponding dib-run-parts change in
    I29f7df1514aeb988222d1094e8269eddb485c2a0 that will greatly increase
    debugability for environment files by deliberately logging what files
    are sourced and consistently turning on tracing around their import.
    
    This isn't strictly necessary (since dib-run-parts with the prior
    change will just turn tracing off after import anyway) but it's a
    decent cleanup for consistency.  A bare-minimum dib-lint check is
    added.  Documentation is updated.
    
    Change-Id: I10f68be0642835a04af7e5a2bc101502f61e5357

commit 3d44a08c53cc9280b33e83fcec8766cb513da126
Author: Markos Chandras <mchandras@suse.de>
Date:   Tue Oct 18 21:02:10 2016 +0100

elements: runtime-ssh-host-keys: Add openssh-client mapping for SUSE
    
    The SUSE 'openssh' package contains the openssh client.
    
    Change-Id: Ic1da63b6c62158b128d44ac48a0657d5d7c53f67

commit 18a664dd32a59b03f7869e117688f158a63d534a
Author: Paul Belanger <pabelanger@redhat.com>
Date:   Wed Sep 28 16:03:52 2016 -0400

Don't use ssh-keygen -A for init scripts
    
    We are running into race conditions with glean, which ssh-keygen -A is
    not handling properly.  So, create a new script to first check if the
    file exists, then use 'yes' to disable overwriting of existing files.
    
    Change-Id: Ie82e1e3f832fcc8f32c7e1335c5f0ee16d36f9a8
    Signed-off-by: Paul Belanger <pabelanger@redhat.com>

commit 89c708ce61999501c564e1a629962940c3b5c791
Author: Markos Chandras <mchandras@suse.de>
Date:   Tue Oct 18 19:02:41 2016 +0100

elements: simple-init: Remove SUSE interfaces
    
    Make sure SUSE interfaces are removed as well.
    
    Change-Id: If993dc606217f2ec243392ac2fa588ebae1cce86

commit fdffa56ff2034f943b13996815a9e216c724e3b5
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Wed Aug 17 16:20:36 2016 +0000

Add element for setting sysctl values
    
    Theres a pretty standard workflow for setting a sysctl value which will
    be applied on image boot which was written by tripleo. Lets move this in
    tree as other folks (like Octavia) would like to depend on it.
    
    Change-Id: I3c266870d417cdba3196f5fa65c4cd634ab13173

commit fd5fbdd4b5c15c613133c5a18c8e83b486ec1dd0
Author: Gregory Haynes <greg@greghaynes.net>
Date:   Sat Jun 25 04:20:04 2016 +0000

Make xenial the ubuntu default
    
    This is the new LTS.
    
    Change-Id: I42a6c0520dde8be21df396e7c2e6fb5ae55d2025

diskimage-builder

DIB fails to build RHEL image

Bug Description

Other bug subscribers

Remote bug watches