debian image w/ironic-agent failing to build

[Julia Kreger]

When attempting to build an ironic-agent based ramdisk utilizing diskimage-builder included with bifrost, the build fails with the following stderr/stdout. Root cause appears to be json incompatible changes made to the pkg-map.

stderr:

dib-run-parts Wed Aug 26 12:49:53 UTC 2015 Running /tmp/in_target.d/install.d/01-package-installs
+ set -eu
+ set -o pipefail
++ dirname /tmp/in_target.d/install.d/01-package-installs
+ package-installs -d /tmp/in_target.d/install.d
+ set -eu
+ set -o pipefail
++ basename /usr/local/bin/package-installs
+ SCRIPTNAME=package-installs
++ getopt -o hd: -n package-installs -- -d /tmp/in_target.d/install.d
+ TEMP=' -d '\''/tmp/in_target.d/install.d'\'' --'
+ '[' 0 '!=' 0 ']'
+ eval set -- ' -d '\''/tmp/in_target.d/install.d'\'' --'
++ set -- -d /tmp/in_target.d/install.d --
+ WORKDIR=
+ true
+ case "$1" in
+ WORKDIR=/tmp/in_target.d/install.d
+ shift 2
+ true
+ case "$1" in
+ shift
+ break
+ '[' -z /tmp/in_target.d/install.d ']'
+ PACKAGES=
++ find /tmp/in_target.d/install.d -maxdepth 1 -name 'package-installs-*'
+ '[' -n '' ']'
+ package-installs-v2 --phase install.d /tmp/package-installs.json
Traceback (most recent call last):
  File "/usr/local/bin/pkg-map", line 130, in <module>
    main()
  File "/usr/local/bin/pkg-map", line 75, in main
    package_names = json.loads(fd.read())
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting , delimiter: line 5 column 7 (char 61)

stdout:

Preparing to unpack .../open-iscsi_2.0.873+git0.3b4b4500-10_amd64.deb ...
locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
Unpacking open-iscsi (2.0.873+git0.3b4b4500-10) ...
Processing triggers for systemd (224-1) ...
Setting up open-iscsi (2.0.873+git0.3b4b4500-10) ...
locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
invoke-rc.d: policy-rc.d denied execution of restart.
invoke-rc.d: policy-rc.d denied execution of start.
Processing triggers for systemd (224-1) ...
Reading package lists...
Building dependency tree...
Reading state information...
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
installing curl from ironic-agent
pkg-map failed

FATAL: all hosts have already failed -- aborting

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/217129

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/217129
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=51816f7dba842c4a99c87018f3c49ec18900d545
Submitter: Jenkins
Branch: master

commit 51816f7dba842c4a99c87018f3c49ec18900d545
Author: Julia Kreger <email address hidden>
Date: Wed Aug 26 09:18:19 2015 -0400

    Fix ironic-image pkg-map

    Fixing the ironic-agent pkg-map by adding missing commas. Validated
    updated form passes json linting. Also includes a listing for curl.

    Change-Id: I1983f7a581be3a5aaa771b19c6609cf12b61a7bb
    Closes-Bug: #1488969