install_grub failing for centos7

[Abel Lopez]

The VM element is failing when building centos7

$ disk-image-create -a amd64 -o centos7.qcow2 centos7 vm
...
dib-run-parts Mon Aug 10 19:16:26 UTC 2015 50-remove-bogus-udev-links completed
+ for target in '$targets'
+ output 'Running /tmp/in_target.d/finalise.d/51-bootloader'
++ date
+ echo dib-run-parts Mon Aug 10 19:16:26 UTC 2015 Running /tmp/in_target.d/finalise.d/51-bootloader
dib-run-parts Mon Aug 10 19:16:26 UTC 2015 Running /tmp/in_target.d/finalise.d/51-bootloader
+ target_tag=51-bootloader
+ date +%s.%N
+ /tmp/in_target.d/finalise.d/51-bootloader
+ set -eu
+ set -o pipefail
+ '[' -n /dev/loop0p1 ']'
+ PART_DEV=/dev/loop0p1
+ [[ amd64 =~ ppc ]]
++ echo /dev/loop0p1
++ sed -e s#p1##
++ sed -e s#mapper/##
+ BOOT_DEV=/dev/loop0
+ DIB_EXTLINUX=0
+ '[' 0 '!=' 0 ']'
+ install_grub2
+ '[' -f /tmp/grub/install ']'
+ source /tmp/grub/install
++ rpm -i /tmp/grub/grub2-2.02-0.16.el7.centos.x86_64.rpm
 package grub2-1:2.02-0.16.el7.centos.x86_64 is already installed
/dev/loop0: [64769]:525639 (/tmp/image.aoY0qNT4/image.raw)

$ echo $?
1

[Abel Lopez (al592b)]

I believe this is because we blindly attempt to install grub, regardless of its installed status.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211334

[OpenStack Infra (hudson-openstack)]

Change abandoned by Abel Lopez (<email address hidden>) on branch: master
Review: https://review.openstack.org/211334
Reason: This change breaks the fedora element

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211683

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ben Nemec (<email address hidden>) on branch: master
Review: https://review.openstack.org/211683
Reason: Yeah, that seems reasonable. As always, feel free to reopen if you feel this change still needs to be made.