ironic-agent element file type incosistency

Bug #1482606 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
diskimage-builder
Fix Released
Low
Lucas Alvares Gomes

Bug Description

The "ramdisk-image-create" command outputs two files, one with a ".initramfs" extension and another with a ".kernel" extension.

The ironic-agent element creates a ramdisk but it doesn't rely on the "ramdisk-image-create" command instead it uses the "disk-image-create" command but outputs a .initramfs and .vmlinuz files.

For keeping the consistency and facilitate scripting against the DIB tool we should use the same file type for all ramdisks being created.

Changed in diskimage-builder:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to diskimage-builder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/210436

Changed in diskimage-builder:
status: New → In Progress
Ben Nemec (bnemec)
Changed in diskimage-builder:
importance: Undecided → Low
Changed in diskimage-builder:
assignee: Lucas Alvares Gomes (lucasagomes) → John Trowbridge (trown)
Changed in diskimage-builder:
assignee: John Trowbridge (trown) → Lucas Alvares Gomes (lucasagomes)
Changed in diskimage-builder:
assignee: Lucas Alvares Gomes (lucasagomes) → John Trowbridge (trown)
Changed in diskimage-builder:
assignee: John Trowbridge (trown) → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to diskimage-builder (master)

Reviewed: https://review.openstack.org/210436
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=ba808fa6ecfb71cd85976e153d7c7755b7a082d0
Submitter: Jenkins
Branch: master

commit ba808fa6ecfb71cd85976e153d7c7755b7a082d0
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Aug 7 13:45:12 2015 +0100

    ironic-agent element to output a .kernel file

    The ironic-agent element is created using the disk-image-create utility
    (even being a ramdisk) and outputs a .vmlinuz file for the kernel
    (different than the ramdisk-image-create which outputs a .kernel file
    for the kernel). This is inconsistent and make scripting against the
    diskimage-builder more complicated if one wants to support different
    types of ramdisk.

    This patch creates a hard link for the .vmlinuz file to a .kernel file
    at the end of the process (to keep backward compatibility) and print a
    deprecation message.

    Depends-On: I81400305f166d62aa4612aab54602abb8178b64c
    Change-Id: I476f9ec9ec4206ece0261eaaf2b4182c6bcbd802
    Closes-Bug: #1482606

Changed in diskimage-builder:
status: In Progress → Fix Committed
Changed in diskimage-builder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.