Ironic sets instance as active even if bootloader installation fails when boot_option is 'local'

[Ramakrishnan G (rameshg87)]

When boot_option is set as 'local', Ironic installs grub which is present on the installed image onto the root disk. When the deployed iamge doesn't have grub, it fails. But Ironic sets instance to active even if the boot loader installation fails.

[Lucas Alvares Gomes (lucasagomes)]

It's important to note that it only happens when using the DIB ramdisk.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169354

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169419

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169354
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=9fb2d14cf10184b22d00038973256a13114bfd17
Submitter: Jenkins
Branch: master

commit 9fb2d14cf10184b22d00038973256a13114bfd17
Author: Ramakrishnan G <email address hidden>
Date: Tue Mar 31 20:31:16 2015 +0000

    Report status of boot loader installation to Ironic

    This commit changes the 80-deploy-ironic script of
    deploy-ironic element to report back the status of
    boot loader install (when boot_option == "local")
    using a newly introduced vendorpassthru.

    Closes-Bug: 1422723
    Change-Id: I9c1d8643be7cb9e273d65ddd791715a5c271fd93

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169419
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=a4b8feb8527752e5c4f6d8900679aab7b67e6248
Submitter: Jenkins
Branch: master

commit a4b8feb8527752e5c4f6d8900679aab7b67e6248
Author: Ramakrishnan G <email address hidden>
Date: Tue Mar 31 16:36:15 2015 +0000

    Check status of bootloader installation for DIB ramdisk

    This commit adds a new vendor passthru
    'pass_bootloader_install_info' for DIB ramdisk to
    notify the status of boot loader installation. The
    same change is made for both pxe_* drivers and iscsi_ilo
    driver.

    Closes-Bug: 1422723
    Depends-on: I9c1d8643be7cb9e273d65ddd791715a5c271fd93
    Change-Id: I9944b6835e42cc9b282b7a7b90191a18d00f2e38