pkg-map incompatible with new install-packages element

Bug #1402085 reported by Abel Lopez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
diskimage-builder
Fix Released
Critical
Abel Lopez

Bug Description

The latest update to install-packages I3f182aa3aae0a79b2f3ea4e66c1878ad12878b0a
 takes input from a file in /tmp/package-installs.json

Unfortunately, this includes error messages, like "Missing package name for distro", which package-installs takes literally and errors out as
E: Unable to locate package Missing
E: Unable to locate package package
E: Unable to locate package name
E: Unable to locate package for
E: Unable to locate package distro
E: Unable to locate package ubuntu
install failed with error Reading package lists...

Simply commenting out the setting of the error fixes it, but it would be nice to redirect this output to console and not the file.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to diskimage-builder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141522

Changed in diskimage-builder:
assignee: nobody → Abel Lopez (al592b)
status: New → In Progress
Changed in diskimage-builder:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to diskimage-builder (master)

Reviewed: https://review.openstack.org/141522
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=da7787069df7c52e82ff6289d23ba8838a014d80
Submitter: Jenkins
Branch: master

commit da7787069df7c52e82ff6289d23ba8838a014d80
Author: Abel Lopez <email address hidden>
Date: Fri Dec 12 15:36:33 2014 -0800

    Ignore stderr from pkg-map

    The latest update to package-install captures both stderr and stdout
    from pkg-map, unfortunately, pkg-map has a 'missing-ok' option
    which causes it to print an error message on stderr.
    The result is that package-install tries to look for packages named
    "Missing", "package", "name", etc.

    Change-Id: I86b3b71a64b29d533b42fd0cae020e8ecf22cac2
    Closes-bug: 1402085

Changed in diskimage-builder:
status: In Progress → Fix Committed
Revision history for this message
Abel Lopez (al592b) wrote :

This is reopened, turns out the original patchset fixed the issue properly, but the subsequent suggestions from the community that created patchset 4 doesn't fix the bug

Changed in diskimage-builder:
status: Fix Committed → In Progress
Revision history for this message
Abel Lopez (al592b) wrote :

May have spoken too soon,

Abel Lopez (al592b)
Changed in diskimage-builder:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.