os-refresh-config install scripts run too early

[Gonéri Le Bouder]

Hi,

os-refresh-config depends on pip-and-virtualenv and expect it to be installed before. This to be able to run virtualenv.

expand_dependencies() correcly identify the dependency but push pip-and-virtualenv after os-refresh-config in the dependencies list.

    'base',
     'boot-stack',
     'cache-url',
     'dib-run-parts',
     'dkms',
     'dpkg',
     'glance',
     'heat',
     'heat-api',
     'heat-engine',
     'iptables',
     'keystone',
     'mysql',
     'network-utils',
     'neutron',
     'neutron-openvswitch-agent',
     'neutron-ovs-cleanup',
     'neutron-server',
     'nova',
     'nova-api',
     'openstack-clients',
     'os-apply-config',
     'os-collect-config',
     'os-refresh-config',
     'os-svc-install',
     'pip-and-virtualenv',
     'source-repositories',
     'ubuntu',
     'use-ephemeral',
     'vm'

I used the following command:

disk-image-create -o bootstrap vm boot-stack ubuntu

[Clint Byrum (clint-fewbar)]

No order is ever implied, the README.md states:

### Dependencies ###

Each element has a file named element-deps: a plain text, newline separated list of elements which will be added to the list of elements built into the image at image creation time.

Ordering is only achieved through lexically sorting scripts in the hook directories.

The bug, therefore, is in tripleo-image-elements/elements/os-refresh-config/install.d/01-os-refresh-config. It should be renamed to 10-os-refresh-config, which would put it well after pip-and-virtualenv's 01-pip-and-virtualenv.

[James Polley (tchaypo)]

Review open at https://review.openstack.org/#/c/81174/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/81174
Committed: https://git.openstack.org/cgit/openstack/tripleo-image-elements/commit/?id=15bdcfe5c055b87355da4be96b3b700a9624553e
Submitter: Jenkins
Branch: master

commit 15bdcfe5c055b87355da4be96b3b700a9624553e
Author: James Polley <email address hidden>
Date: Wed Mar 19 13:03:27 2014 +0000

    Make os-refresh-config install.d hook run later

    os-refresh-config relies on being able to run virtualenv, which is only
    guaranteed to be possible after running 01-install-pip from the
    pip-and-virtualenv element.

    To guarantee this ordering, move
    install.d/os-refresh-config-source-install/01-os-refresh-config to
    install.d/os-refresh-config-source-install/10-os-refresh-config

    And for consistency in script execution timing, move
    install.d/os-refresh-config-package-install/01-os-refresh-config to
    install.d/os-refresh-config-package-install/10-os-refresh-config

    Change-Id: I3b0a127c0c6eca16854f84a3c733cbd54c8a4880
    Closes-Bug: #1292514