80-deploy-ironic gets keystone auth token from wrong tftp location

[Adam Gandelman]

The ramdisk created with deploy-ironic element requires fetching a Keystone auth token from the tftp server:

TOKEN_FILE=token-$DEPLOYMENT_ID

if tftp -r /tftpboot/$TOKEN_FILE -g $BOOT_SERVER
then TOKEN_HEADER="-H 'X-Auth-Token: `cat $TOKEN_FILE`'"
else TOKEN_HEADER=""
fi

This fails (at least using atftp setup with devstack[1]). On the tftp server side:

File /opt/stack/data/ironic/tftpboot//tftpboot/token-acb4157e-34ba-4b88-bba2-3bdb7920aef1 not found

Tokens are stored in the root of the configured server-side tftpboot directory. The element should fetch from there accordingly

[1] atftpd --port 69 --bind-address 10.0.0.251 -t 60 -m 50 --daemon --user ubuntu /opt/stack/data/ironic/tftpboot

[Adam Gandelman (gandelman-a)]

Seems this is handled on in tripleO's tftp server setup: https://review.openstack.org/#/c/53398/ ( which was later copied to ironic-conductor setup). the WIP devstack patch has been updated to configure its tftp server similarly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80596

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/80596
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=7d50c04bf77296f4db9f3c98ed7513598e270676
Submitter: Jenkins
Branch: master

commit 7d50c04bf77296f4db9f3c98ed7513598e270676
Author: Alexander Gordeev <email address hidden>
Date: Thu Mar 13 16:36:14 2014 +0400

    Remove hardcoded /tftpboot/ from token's tftp path

    Since file to be fetched from the root tftp directory it shouldn't
    contain any hardcoded path. Additionaly it eliminates bearing with
    map-file containing regular expressions for tftp path replacement.

    Change-Id: Iee1672834f735d7dfefce43000540522e1d053b9
    Closes-Bug: #1291533