distinction between env vars and options is not clear

Bug #1168443 reported by Devananda van der Veen on 2013-04-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
diskimage-builder
Low
Unassigned

Bug Description

For both disk-image-create and ramdisk-image-create, there isn't currently a clear distinction between what is (or should be) set via ENV var and what should be set as a command-line option. Furthermore, some settings (eg, IMAGE_NAME vs "-o <name>") can be set either way, which is quite confusing.

Chris Jones proposed:
  If a setting controls the overall build environment,
  it's an env var, but if it controls a specific feature of the build, it's an argument. TMP_DIR is unlikely
  to change if you do 20 builds in a row, but -o is extremely likely to be build-specific

I think this is a reasonable distinction, and some of the older code (eg, lib/img-defaults) needs a bit of cleanup.

Changed in diskimage-builder:
status: New → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers