Activity log for bug #1745877

Date Who What changed Old value New value Message
2018-01-28 21:05:19 Timothy bug added bug
2018-01-28 21:08:57 Timothy description Gee collections should really be returned from publicly visible API. Other languages (notable Gjs) have trouble with Gee do to its heavy use of generics. The solution would be to return the Gee collection wrapped in a class with a hardcoded type. Something like public class ClipboardItemList { private List<IClipboardItem> list; public ClipboardItemList(List<IClipboardItem> list) { this.list = list; } public IClipboardItem get (int i) { return this.list[i]; } } Gee collections shouldn't really be returned from publicly visible API. Other languages (notable Gjs) have trouble with Gee do to its heavy use of generics. The solution would be to return the Gee collection wrapped in a class with a hardcoded type. Something like public class ClipboardItemList {   private List<IClipboardItem> list;   public ClipboardItemList(List<IClipboardItem> list) {     this.list = list;   }   public IClipboardItem get (int i) {     return this.list[i];   } }
2018-01-28 21:09:42 Timothy description Gee collections shouldn't really be returned from publicly visible API. Other languages (notable Gjs) have trouble with Gee do to its heavy use of generics. The solution would be to return the Gee collection wrapped in a class with a hardcoded type. Something like public class ClipboardItemList {   private List<IClipboardItem> list;   public ClipboardItemList(List<IClipboardItem> list) {     this.list = list;   }   public IClipboardItem get (int i) {     return this.list[i];   } } Gee collections shouldn't really be returned from publicly visible API. Other languages (notable Gjs) have trouble with Gee do to its heavy use of generics. The solution would be to return the Gee collection wrapped in a class with a hardcoded type. Something like public class ClipboardItemList {   private List<IClipboardItem> list;   public ClipboardItemList(List<IClipboardItem> list) {     this.list = list;   }   public IClipboardItem get (int i) {     return this.list[i];   } ... }
2018-01-28 21:10:26 Timothy description Gee collections shouldn't really be returned from publicly visible API. Other languages (notable Gjs) have trouble with Gee do to its heavy use of generics. The solution would be to return the Gee collection wrapped in a class with a hardcoded type. Something like public class ClipboardItemList {   private List<IClipboardItem> list;   public ClipboardItemList(List<IClipboardItem> list) {     this.list = list;   }   public IClipboardItem get (int i) {     return this.list[i];   } ... } Gee collections shouldn't really be returned from publicly visible API. Other languages (notable Gjs) have trouble with Gee do to its heavy use of generics. The solution would be to return the Gee collection wrapped in a class with a hardcoded type. Something like public class ClipboardItemList {   private List<IClipboardItem> list;   public ClipboardItemList(List<IClipboardItem> list) {     this.list = list;   }   public IClipboardItem get (int i) {     return this.list[i];   }   ... } Is this something we want to address?
2018-01-29 08:06:04 Oliver Sauder diodon: status New Confirmed
2018-01-30 08:07:20 Oliver Sauder summary libdion is not accessible from Gjs Remove gee dependency and replace it with GLib native types
2018-01-30 08:08:29 Oliver Sauder description Gee collections shouldn't really be returned from publicly visible API. Other languages (notable Gjs) have trouble with Gee do to its heavy use of generics. The solution would be to return the Gee collection wrapped in a class with a hardcoded type. Something like public class ClipboardItemList {   private List<IClipboardItem> list;   public ClipboardItemList(List<IClipboardItem> list) {     this.list = list;   }   public IClipboardItem get (int i) {     return this.list[i];   }   ... } Is this something we want to address? Gee is highly Vala specific and causes issues with GObject introspection to be used e.g. by gjs or python. Hence dependency on Gee should be completely removed. Original description: Gee collections shouldn't really be returned from publicly visible API. Other languages (notable Gjs) have trouble with Gee do to its heavy use of generics. The solution would be to return the Gee collection wrapped in a class with a hardcoded type. Something like public class ClipboardItemList {   private List<IClipboardItem> list;   public ClipboardItemList(List<IClipboardItem> list) {     this.list = list;   }   public IClipboardItem get (int i) {     return this.list[i];   }   ... } Is this something we want to address?
2018-01-30 08:08:33 Oliver Sauder diodon: status Confirmed Triaged
2018-01-30 08:08:37 Oliver Sauder diodon: importance Undecided Medium
2018-02-03 09:30:28 Timothy attachment added 0001-LP-1745877-Remove-gee-dependency.patch https://bugs.launchpad.net/diodon/+bug/1745877/+attachment/5047909/+files/0001-LP-1745877-Remove-gee-dependency.patch
2018-02-03 17:04:11 Oliver Sauder diodon: status Triaged Fix Committed
2018-02-03 17:26:29 Oliver Sauder diodon: milestone 1.8.0
2018-03-11 20:25:03 Oliver Sauder diodon: status Fix Committed Fix Released