Open own list when using get/browse file list on self

[inactive]

Feature|Mod

Issue: When attempting to "download" your own filelist via the userlist (rightclick -> get filelist) you're greeted with the status/warning-message: "You're trying to download from yourself!" and the action is thus canceled.

Suggestion: If it's not meant to be used then either remove it or change it so that the user can OPEN his own list via the user-list menu.

[eMTee (realprogger)]

It's the same error message you get from any lists, actually it's generated when you try to add yourself as a source for any queue item.
The message itself is OK, however it would be nice to either remove the file list related context menus for own CID or better open the own list instead of trying to add a filelist item to the queue.

[Fredrik Ullner (ullner)]

Attached patch is using an exception as system logic. I don't know if this is acceptable or not, it was simply to avoid having to check for 'self' multiple times.

[poy (poy)]

that's inventive... it's fine by me. :)

however:

1) make QueueSelfException derive from QueueException instead of Exception, so that callers catching QueueException would still be able to receive QueueSelfExceptions.

2) can you check how this works from searches and finished transfer windows? these use WinUtil::addUserItems, which might benefit from these changes as well.

[Fredrik Ullner (ullner)]

1. Included in this patch. I added ability to extend an exception in Exception.h

2. You can't select yourself in the searchframe or finished downloads so that won't be applicable...

[poy (poy)]

perfect, push it! :)

[poy (poy)]

Fixed in DC++ 0.840.