Org unit tree selection misbehaving for users with restricted access

Bug #1230385 reported by Lars Helge Øverland on 2013-09-25
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
DHIS
Critical
Morten Olav Hansen

Bug Description

Assuming current user has access to only a lower part of the organisation unit hierarchy. This is enforced by displaying only that subtree in the org unit selection tree. In edit org unit group screen, when editing an existing group, then organisation units which are hidden from the view will be unintentionally un-selected. It should not be possible to un-select org units in this way.

This might lead to large selections being cleared.

Affects org unit group, data set - org unit assignment.

This applies to data set > org unit and program > org unit association.

Changed in dhis2:
importance: Undecided → Critical
milestone: none → 2.13
assignee: nobody → Lars Helge Øverland (larshelge)
Dapo Adejumo (dapo-adejumo) wrote :

Hi Lars,
Any hope this will be sorted soon?

Changed in dhis2:
assignee: Lars Helge Øverland (larshelge) → Morten Olav Hansen (mortenoh)
description: updated
Morten Olav Hansen (mortenoh) wrote :

This has been fixed dataSets, for programs it was already working.

Changed in dhis2:
status: New → Fix Committed
Dapo Adejumo (dapo-adejumo) wrote :

Hi, Bug still exists......tested on demo and trunk.

Morten Olav Hansen (mortenoh) wrote :

Can you give more information? the use-case I have been tested on still works as it should...

1. Create a new user, assign to Bo
2. Login as user, change a dataset to only be on Bo
3. Login as system user again, now dataset has only been changed for the Bo sub-tree

Did we test that this also is okay now for the org unit group -> org unit
assignment?

On Fri, Nov 29, 2013 at 2:11 PM, Morten Olav Hansen <
<email address hidden>> wrote:

> Can you give more information? the use-case I have been tested on still
> works as it should...
>
> 1. Create a new user, assign to Bo
> 2. Login as user, change a dataset to only be on Bo
> 3. Login as system user again, now dataset has only been changed for the
> Bo sub-tree
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1230385
>
> Title:
> Org unit tree selection misbehaving for users with restricted access
>
> Status in DHIS 2:
> Fix Committed
>
> Bug description:
> Assuming current user has access to only a lower part of the
> organisation unit hierarchy. This is enforced by displaying only that
> subtree in the org unit selection tree. In edit org unit group screen,
> when editing an existing group, then organisation units which are
> hidden from the view will be unintentionally un-selected. It should
> not be possible to un-select org units in this way.
>
> This might lead to large selections being cleared.
>
> Affects org unit group, data set - org unit assignment.
>
> This applies to data set > org unit and program > org unit
> association.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/dhis2/+bug/1230385/+subscriptions
>

Morten Olav Hansen (mortenoh) wrote :

Everything should be working fine, but it would be nice if Dapo could confirm.

Dapo Adejumo (dapo-adejumo) wrote :

Yes...Its fine now.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers