Share menu doesn't have icons

[Danielle Foré]

The share menu should have nice big sexy icons to help more quickly pick out the intended action.

I'm thinking maybe 32's ?

[Allen Lowe (lallenlowe)]

this is turning out to be very difficult, because you have to set the gconf key to show images in gtk menus.

[Cris Dywan (kalikiana)]

Use set_always_show_image(true) on the menu item. That's what Midori uses for bookmark icons.

[Allen Lowe (lallenlowe)]

well, I figured out how to do it, but I don't think I want to override the system behavior and show icons....

[Allen Lowe (lallenlowe)]

it seems evil to me

[Danielle Foré (danrabbit)]

Personally, I think this is a case where we should override the system behavior. There doesn't seem to be a middle setting. It's "don't show icons" or "show icons" instead of "show icons only when appropriate."

I think the closest we can get to that middle ground is to "not show icons" and force override in these kinds of cases.

[Allen Lowe (lallenlowe)]

this bug is really pissing me off, I've been working on it for 2 days, and I can't get the damned menu to show icons...

[Jean-Alexandre Anglès d'Auriac (jagw40k)]

How comes it is not showing icon even when the gconf key is set to show menu icons ?

[Allen Lowe (lallenlowe)]

because I disabled the code, it was broken