[neutron] Drop lib/neutron module

[Slawek Kaplonski]

It was discussed and decided during 2023.1 PTG [1] that we should drop lib/neutron module as it was never finished and used really. Once this will be done, old module called currently lib/neutron-legacy should be renamed to lib/neutron.
In that new (old) module we should allow both q- and neutron- prefixes for services.

[Slawek Kaplonski (slaweq)]

Patches:
https://review.opendev.org/c/openstack/devstack/+/865014
https://review.opendev.org/c/openstack/devstack/+/865015

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/devstack/+/865544

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/devstack/+/865544
Committed: https://opendev.org/openstack/devstack/commit/30acfc6d14bb42db822352426cc2d4e337717c72
Submitter: "Zuul (22348)"
Branch: master

commit 30acfc6d14bb42db822352426cc2d4e337717c72
Author: Slawek Kaplonski <email address hidden>
Date: Thu Nov 24 14:12:08 2022 +0100

    [neutron] Don't configure firewall_driver for core ML2 plugin

    In the past firewall_driver setting was configured for ML2 plugin
    because it was used in the
    neutron.agent.securitygroups_rpc.is_firewall_enabled() function but
    currently it's not needed anymore as there is other config option
    "enable_security_group" for that.

    Related-bug: #1996748
    Change-Id: I9b09c6afb3f1f1c33d1bdfea52ba6f4c0d0cf2dc

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/devstack/+/865015
Reason: It's squashed with https://review.opendev.org/c/openstack/devstack/+/865014

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/devstack/+/865014
Committed: https://opendev.org/openstack/devstack/commit/a52041cd3f067156e478e355f5712a60e12ce649
Submitter: "Zuul (22348)"
Branch: master

commit a52041cd3f067156e478e355f5712a60e12ce649
Author: Slawek Kaplonski <email address hidden>
Date: Fri Nov 18 11:39:56 2022 +0100

    Drop lib/neutron module

    Module lib/neutron was introduced long time ago as new module to deploy
    neutron. It was intended to replace old lib/neutron-legacy module. But
    since very long time it wasn't really finished and used by anyone and
    lib/neutron-legacy is defacto standard module used by everyone to deploy
    neutron with devstack.
    In [1] unfinished lib/neutron was deprecated and now it's time to remove
    it from the devstack code.

    This patch also renames old "lib/neutron-legacy" module to be
    "lib/neutron" now.

    Previously "old" lib/neutron-legacy module was accepting neutron
    services names wit "q-" prefix and "new" lib/neutron module was accepting
    services with "neutron-" prefix. Now, as there is only one module it
    accepts both prefixes.
    For historical reasons and to be consistent with old lib/neutron-legacy
    which was widely used everywhere, services will be named with "q-"
    prefix but both prefixes will be accepted to enable or disable services.

    This patch also moves _configure_neutron_service function to be called
    at the end of the "configure_neutron" after all agents and service
    plugins are already configured.

    [1] https://review.opendev.org/c/openstack/devstack/+/823653

    Related-bug: #1996748

    Change-Id: Ibf1c8b2ee6b6618f77cd8486e9c687993d7cb4a0