Config file corrupted by options containing the ampersand character (&)

[Nobuhiro MIKI]

Attempting to set a value containing the ampersand character (&) by iniset would corrupt the value.
Here is an example.

$ iniset /etc/glance/glance-api.conf database connection 'mysql+pymysql://root:stackdb@127.0.0.1/glance?charset=utf8&plugin=dbcounter'

When the above iniset is called multiple times, the value would be corrupted as follows.

# First time
connection = mysql+pymysql://root:stackdb@127.0.0.1/glance?charset=utf8&plugin=dbcounter

# Second time
connection = mysql+pymysql://root:stackdb@127.0.0.1/glance?charset=utf8connection = mysql+pymysql://root:stackdb@127.0.0.1/glance?charset=utf8&plugin=dbcounterplugin=dbcounter

# Third time
connection = mysql+pymysql://root:stackdb@127.0.0.1/glance?charset=utf8connection = mysql+pymysql://root:stackdb@127.0.0.1/glance?charset=utf8connection = mysql+pymysql://root:stackdb@127.0.0.1/glance?charset=utf8&plugin=dbcounterplugin=dbcounterplugin=dbcounter

This is reproduced in a very simple example as follows
$ iniset /tmp/dummy database connection '&y'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/devstack/+/852378

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/devstack/+/852378
Committed: https://opendev.org/openstack/devstack/commit/d266c87b1d3ecae1b40589832efc9bf7cf3e524c
Submitter: "Zuul (22348)"
Branch: master

commit d266c87b1d3ecae1b40589832efc9bf7cf3e524c
Author: Nobuhiro MIKI <email address hidden>
Date: Mon Aug 8 16:45:31 2022 +0900

    iniset: fix handling of values containg ampersand

    Attempting to set a value containing the ampersand
    character (&) by iniset would corrupt the value.
    So, add an escaping process.

    Signed-off-by: Nobuhiro MIKI <email address hidden>
    Closes-Bug: #1983816
    Change-Id: Ie2633bacd2d761d110e6cb12f95382325c329415