New role 'capture-performance-data' failing when pymysql is not installed

Bug #1970195 reported by Fernando Royo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Unassigned

Bug Description

New role 'capture-performance-data' is failing on that jobs where pymysql module is not installed, reporting following error:

TASK [capture-performance-data : Generate statistics]
controller | Traceback (most recent call last):
controller | File "/opt/stack/devstack//tools/get-stats.py", line 14, in <module>
controller | import pymysql
controller | ModuleNotFoundError: No module named 'pymysql'

Some example of jobs error are located in [1] or [2]

[1] https://zuul.opendev.org/t/openstack/build/00701df174b04f4286700ee59865ca84
[2] https://zuul.opendev.org/t/openstack/build/2c567ef1f7bf4b89a8de41dbf8073a32

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/devstack/+/839193

Changed in devstack:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to devstack (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/devstack/+/839217

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to devstack (master)

Reviewed: https://review.opendev.org/c/openstack/devstack/+/839217
Committed: https://opendev.org/openstack/devstack/commit/1b601c7b1e8a3ec4816cb827ccd8bf909a05debb
Submitter: "Zuul (22348)"
Branch: master

commit 1b601c7b1e8a3ec4816cb827ccd8bf909a05debb
Author: Dan Smith <email address hidden>
Date: Mon Apr 25 07:47:56 2022 -0700

    Tolerate missing deps in get-stats.py

    In order to run on systems where not all requirements are present,
    we should be tolerant of missing external dependencies, such as
    psutil and pymysql. Print a warning (to stderr) and just leave out
    those stats in that case.

    Also make running the stats collector use ignore_errors:yes to avoid
    failures in the future. I think the stats is not critical enough to
    fail a job for bugs like this.

    Related-Bug: #1970195
    Change-Id: I132b0e1f5033c4f109a8b8cc776c0877574c4a49

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on devstack (master)

Change abandoned by "Fernando Royo <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/devstack/+/839193
Reason: Cover by https://review.opendev.org/c/openstack/devstack/+/839217

Revision history for this message
Martin Kopec (mkopec) wrote :

It's been decided to tolerate the missing dep by https://review.opendev.org/c/openstack/devstack/+/839217

Changed in devstack:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.