Some arping version only accept integer number as -w argument

[Rodolfo Alonso]

For example, Bionic v2.19-4 accepts "4.5", but not Focal v2.20-1.

LOG:
stack@u20:/opt/stack$ arping -A -c 3 -w 4.5 -I br-ex 192.168.20.70
arping: invalid argument: '4.5'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/738082

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/738082
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=ca486c5259277db72c73c661ef3e9620a3b65d49
Submitter: Zuul
Branch: master

commit ca486c5259277db72c73c661ef3e9620a3b65d49
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Jun 25 18:22:28 2020 +0000

    Provide integer number to arping "-w" parameter

    Some arping versions only accept an integer number for the
    "deadline" (-w) parameter.

    Change-Id: Ie21c9b5820262d049c0fcd8147d85cc110d88272
    Closes-Bug: #1885169

[Chris MacNaughton (chris.macnaughton)]

I've added Focal and Neutron bug tasks to this, as it affects Ussuri still.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/800868

[Edward Hope-Morley (hopem)]

I just tested arping on Focal and I dont see this issue:

ubuntu@arping:~$ sudo arping -U -I eth0 -c 1 -w 1.5 10.48.98.1
ARPING 10.48.98.1
42 bytes from fe:10:17:12:6a:9c (10.48.98.1): index=0 time=14.516 usec

--- 10.48.98.1 statistics ---
1 packets transmitted, 1 packets received, 0% unanswered (0 extra)
rtt min/avg/max/std-dev = 0.015/0.015/0.015/0.000 ms
ubuntu@arping:~$ dpkg -l| grep arping
ii arping 2.20-1 amd64 sends IP and/or ARP pings (to the MAC address)

Not sure what i'm missing.

[Chris MacNaughton (chris.macnaughton)]

For the record, it works the same for me on Impish as Ed shows above

[Nobuto Murata (nobuto)]

On focal, there are two packages offering arping binary:

[iputils-arping(main)]
$ sudo arping -U -I eth0 -c 1 -w 1.5 10.48.98.1
arping: invalid argument: '1.5'

[arping(universe)]
$ arping -U -I eth0 -c 1 -w 1.5 10.48.98.1
ARPING 10.48.98.1

I don't know which one our charms install.

[Nobuto Murata (nobuto)]

It's likely iputils-arping.

$ apt rdepends arping
arping
Reverse Depends:
  Conflicts: iputils-arping
  Depends: netconsole
  Depends: ifupdown-extra

$ apt rdepends iputils-arping
iputils-arping
Reverse Depends:
  Depends: neutron-l3-agent
  Recommends: python3-networking-arista
  Recommends: neutron-mlnx-agent
  Depends: neutron-l3-agent
  Recommends: whereami
  Recommends: python3-networking-arista
  Recommends: neutron-mlnx-agent
 |Depends: netconsole
  Depends: libguestfs-rescue
 |Depends: ifupdown-extra
  Depends: dracut-network
  Conflicts: arping

[Pedro Guimarães (pguimaraes)]

I've ran a test with both arping and iputils-arping. I can notice that using the "arping" package, indeed it works fine, just like @hopem commented previously. However, if we run with "iputils-arping" package, then I see the same issue:

$ sudo arping -A -I <IF> -c 1 -w 1.5 127.0.0.1
arping: invalid argument: '1.5'

As @nobuto mentioned, iputils-arping is the package we are interested on and therefore, we need this fix on Neutron packages.

[James Page (james-page)]

This fix was included with the victoria release of Neutron so only focal/ussuri is impacted.

[Chris MacNaughton (chris.macnaughton)]

This fix has been uploaded to the Focal unapproved queue (https://launchpad.net/ubuntu/focal/+queue?queue_state=1&queue_text=neutron)

[Edward Hope-Morley (hopem)]

For context this somewhat explains what changes occurred in iputils to lead to this issue - https://github.com/iputils/iputils/issues/267

[Brian Murray (brian-murray)]

Hello Rodolfo, or anyone else affected,

Accepted neutron into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/neutron/2:16.4.0-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Billy Olsen (billy-olsen)]

With the package now in -proposed, dropping field-critical and moving to field-high as workaround is available.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/800868
Committed: https://opendev.org/openstack/neutron/commit/577be337b9a69c28383a28aab0d08149bfca8ce8
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 577be337b9a69c28383a28aab0d08149bfca8ce8
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jun 29 08:45:56 2020 +0000

    Provide integer number to arping "-w" parameter

    Some arping versions only accept an integer number for the
    "deadline" (-w) parameter.

    Change-Id: Icf5e2a73b15407419d5c922e236181af85aad0dc
    Closes-Bug: #1885169
    (cherry picked from commit 72d95d40d467fa43a53a48bbc93f6efb3a43fca6)

[Pedro Guimarães (pguimaraes)]

Hi,

We've run a test with -proposed version and our tests have been successful.

Test scenario:
Run Rally test "VMTasks.boot_runcommand_delete" 4x times with 2x as concurrency

That fails on our current environment without the patch because some VMs are unreachable for several minutes.
Once we've upgraded to the new package, the test successfully finished.

I am moving the tag to validation done on Focal.

[Pedro Guimarães (pguimaraes)]

Hi, here is the output of "apt policy python3-neutron": https://pastebin.ubuntu.com/p/8xt5mdMkVg/

It shows: 16.4.0-0ubuntu2 as installed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package neutron - 2:16.4.0-0ubuntu2

---------------
neutron (2:16.4.0-0ubuntu2) focal; urgency=medium

  * d/p/provide-integer-argument-to-arping.patch: Cherry-pick upstream
    patch to ensure gratuitous APRs are correctly sent (LP: #1885169).

neutron (2:16.4.0-0ubuntu1) focal; urgency=medium

  * New stable point release for OpenStack Ussuri (LP: #1935030).
  * Remove patches that have landed upstream in this point release:
    - d/p/updates-for-python3.8.patch
    - d/p/0001-Update-arp-entry-of-snat-port-on-qrouter-ns.patch

 -- Chris MacNaughton <email address hidden> Fri, 16 Jul 2021 14:25:28 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for neutron has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 16.4.1 release.