devstack

Glance registry should not be required to run since Queens

Bug #1859847 reported by Radosław Piliszek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Goutham Pacha Ravi
OpenStack Shared File Systems Service (Manila) victoria-1
devstack
Fix Released
Medium
Radosław Piliszek

Bug Description

Per https://specs.openstack.org/openstack/glance-specs/specs/queens/approved/glance/deprecate-registry.html

Currently devstack forces deployment of Glance registry because Glance initialization depends on it.

Radosław Piliszek (yoctozepto)
Changed in devstack:
assignee: nobody → Radosław Piliszek (yoctozepto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.opendev.org/702707

Changed in devstack:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to devstack (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/702709

Dr. Jens Harbott (j-harbott)
Changed in devstack:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.opendev.org/702707
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=d8dec362baa2bf7f6ffe1c47352fdbe032eaf20a
Submitter: Zuul
Branch: master

commit d8dec362baa2bf7f6ffe1c47352fdbe032eaf20a
Author: Radosław Piliszek <email address hidden>
Date: Wed Jan 15 18:30:36 2020 +0100

    Run Glance initialization when Glance is enabled, not just registry

    Per [1] Glance registry should not be required to run since Queens.

    [1] https://specs.openstack.org/openstack/glance-specs/specs/queens/approved/glance/deprecate-registry.html

    Change-Id: I5477c8769ff4ae151d4d6ccb5e5d8dd5788909b0
    Closes-bug: #1859847

Changed in devstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to devstack (master)

Reviewed: https://review.opendev.org/702709
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=d7dfcdb4674daae8a294848b1de6fa87c5d7d4eb
Submitter: Zuul
Branch: master

commit d7dfcdb4674daae8a294848b1de6fa87c5d7d4eb
Author: Radosław Piliszek <email address hidden>
Date: Wed Jan 15 18:36:20 2020 +0100

    Stop enabling g-reg by default

    Per [1] Glance registry should not be required to run since Queens.

    [1] https://specs.openstack.org/openstack/glance-specs/specs/queens/approved/glance/deprecate-registry.html

    Change-Id: I93325cbd26dbc6a30062d9ba83acab248897b18e
    Depends-on: https://review.opendev.org/702707
    Related-bug: #1859847

Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

This got reverted to unbreak nova gates: https://bugs.launchpad.net/devstack/+bug/1860021

Testing the failing job proposed in https://review.opendev.org/703271

TODO: fix this one without breaking nova :-)

Some analysis already in comment: https://bugs.launchpad.net/devstack/+bug/1860021/comments/16

Changed in devstack:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.opendev.org/703288

OpenStack Infra (hudson-openstack)
Changed in devstack:
assignee: Radosław Piliszek (yoctozepto) → Dr. Jens Harbott (j-harbott)
Radosław Piliszek (yoctozepto)
Changed in devstack:
assignee: Dr. Jens Harbott (j-harbott) → Radosław Piliszek (yoctozepto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.opendev.org/703288
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=09e860fc2c306774076c1814ba3ab7c44404066d
Submitter: Zuul
Branch: master

commit 09e860fc2c306774076c1814ba3ab7c44404066d
Author: Radosław Piliszek <email address hidden>
Date: Sun Jan 19 12:41:14 2020 +0100

    Run Glance initialization when Glance is enabled, not just registry (v2)

    Per [1] Glance registry should not be required to run since Queens.

    v2 improves on v1 [2] (now reverted [3]) by applying minor comments
    from reviews so far and ensuring nova-live-migration job does not see
    a change in behavior and hence does not break [4].
    [5] tried to fix the issue but it did only partially, regarding
    the database but not the image upload [6].
    This patch ensures double cirros image upload does not happen as well.

    [1] https://specs.openstack.org/openstack/glance-specs/specs/queens/approved/glance/deprecate-registry.html
    [2] https://review.opendev.org/702707
    [3] https://review.opendev.org/703131
    [4] https://bugs.launchpad.net/devstack/+bug/1860021
    [5] https://review.opendev.org/702960
    [6] https://bugs.launchpad.net/devstack/+bug/1860021/comments/16

    Change-Id: I61538acd6bd4c7b3da26c4084225b220d7d1aa2c
    Closes-bug: #1859847
    Related-bug: #1860021

Changed in devstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to devstack (master)

Reviewed: https://review.opendev.org/703247
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=89cb80d2120a7247dcc8b1f6a073cf9c9e488806
Submitter: Zuul
Branch: master

commit 89cb80d2120a7247dcc8b1f6a073cf9c9e488806
Author: Radosław Piliszek <email address hidden>
Date: Sat Jan 18 15:41:17 2020 +0000

    Revert "Revert "Stop enabling g-reg by default""

    This reverts commit 98f3bbe509c2de9efaf4f3fc1b5dbc42d7a67987.

    This is no longer necessary as proper fix [1]
    is now applied.

    [1] https://review.opendev.org/703288

    Change-Id: Ibc40f79b1daf30246ed24790e9b305caea497cb2
    Related-bug: #1859847
    Related-bug: #1860021

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/724201

Changed in manila:
assignee: nobody → Goutham Pacha Ravi (gouthamr)
status: New → In Progress
Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: none → victoria-1
Goutham Pacha Ravi (gouthamr)
Changed in manila:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/724201
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ffb283a04a27d87ff7f9c74ead7778efb68b0255
Submitter: Zuul
Branch: master

commit ffb283a04a27d87ff7f9c74ead7778efb68b0255
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Apr 28 16:41:00 2020 -0700

    [devstack][ci] Stop requiring g-reg service

    When using manila's devstack plugin, we pull down
    the latest manila testing image created with the
    manila-image-elements project, and upload it to the
    stack's Glance/Image service.

    Glance's V2 API no longer needs g-reg which was a
    legacy database proxy service for the older glance
    API. Our devstack plugin should not have a hard
    dependency on this service.

    [1] http://lists.openstack.org/pipermail/openstack-dev/2016-May/094773.html
    [2] https://specs.openstack.org/openstack/glance-specs/specs/newton/approved/glance/deprecate-registry.html

    Change-Id: I58603032fb215ac0be2f76c8cd9fbce775be41dd
    Closes-Bug: #1859847

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/724431

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/ussuri)

Reviewed: https://review.opendev.org/724431
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=58105a2d68a3530d13f262b9604500eab3a3c941
Submitter: Zuul
Branch: stable/ussuri

commit 58105a2d68a3530d13f262b9604500eab3a3c941
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Apr 28 16:41:00 2020 -0700

    [devstack][ci] Stop requiring g-reg service

    When using manila's devstack plugin, we pull down
    the latest manila testing image created with the
    manila-image-elements project, and upload it to the
    stack's Glance/Image service.

    Glance's V2 API no longer needs g-reg which was a
    legacy database proxy service for the older glance
    API. Our devstack plugin should not have a hard
    dependency on this service.

    [1] http://lists.openstack.org/pipermail/openstack-dev/2016-May/094773.html
    [2] https://specs.openstack.org/openstack/glance-specs/specs/newton/approved/glance/deprecate-registry.html

    Change-Id: I58603032fb215ac0be2f76c8cd9fbce775be41dd
    Closes-Bug: #1859847
    (cherry picked from commit ffb283a04a27d87ff7f9c74ead7778efb68b0255)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/729647

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (stable/train)

Change abandoned by Goutham Pacha Ravi (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/729647
Reason: Looks like we'll need the g-reg service here because the openstackclient v4.0.0 uses
glanceclient and talks with the image service v1 API in the stable/train branch.

Not a big deal - we were chasing this for landing zuulv3 native jobs on this branch, but we'll ensure not to turn off g-reg in stable/train and older branches.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.