Function is_neutron_legacy_enabled works wrong if some neutron services are in disabled list

[Slawek Kaplonski]

If some neutron services, like e.g. neutron-qos or neutron-trunk are in list of DISABLED_SERVICES function is_neutron_legacy_enabled will return 1 even if some "q-" services, like "q-qos" or "q-agt" are in ENABLED_SERVICES list.

It is like that because this function matches for "neutron" string in DISABLED_SERVICES and "neutron-" also match it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/652782

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/652782
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=a9a51ca6382eb01c99fce51084f64a69f4c7d58a
Submitter: Zuul
Branch: master

commit a9a51ca6382eb01c99fce51084f64a69f4c7d58a
Author: Slawek Kaplonski <email address hidden>
Date: Mon Apr 15 23:54:31 2019 +0200

    Fix is_neutron_legacy_enabled function

    This function will now first filter out all "neutron-" strings from
    DISABLED_SERVICES list before looking for "neutron" string in it.

    Change-Id: I5cab6a3be553713e1257599fb72042c6001f2672
    Close-Bug: #1824884

[Martin Kopec (mkopec)]

This should be fixed by https://review.opendev.org/c/openstack/devstack/+/652782/ - there was a typo in the commit message which caused that this LP wasn't closed when the patch got merged.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/c/openstack/devstack/+/854144

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/devstack/+/854144
Committed: https://opendev.org/openstack/devstack/commit/acd107c87f1e58d91addbf24f6b7ebda11d8d26d
Submitter: "Zuul (22348)"
Branch: stable/stein

commit acd107c87f1e58d91addbf24f6b7ebda11d8d26d
Author: Slawek Kaplonski <email address hidden>
Date: Mon Apr 15 23:54:31 2019 +0200

    Fix is_neutron_legacy_enabled function

    This function will now first filter out all "neutron-" strings from
    DISABLED_SERVICES list before looking for "neutron" string in it.

    Change-Id: I5cab6a3be553713e1257599fb72042c6001f2672
    Close-Bug: #1824884
    (cherry picked from commit a9a51ca6382eb01c99fce51084f64a69f4c7d58a)