local install fails on stable/queens with tempest enabled

[Vlad Gridin]

Steps to reproduce:
- git clone https://git.openstack.org/openstack-dev/devstack
- cd devstack && git checkout stable/queens
- ./stack.sh

Failure:
2019-03-13 17:26:47.423 | ++lib/tempest:configure_tempest:563 git -C /opt/stack/requirements show master:upper-constraints.txt
2019-03-13 17:26:47.442 | fatal: Invalid object name 'master'.
2019-03-13 17:26:47.517 | +lib/tempest:configure_tempest:1 exit_trap

Commits [1] [2] introduced use of master branch for requirements iso checked out stable branch
when installing tempest and tempest plugins. That works fine in gate. However when running
stack.sh locally master branch is not tracked, and 'git show' fails.
There is a partial fix [3] in Rocky, which does fix install of tempest, but stack.sh will still
fail if TEMPEST_PLUGINS is specified in local.conf.

[1] https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=e06cc1558b4ca09793a05b699b599fcac2aede5c
[2] https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=e89179e82f945f3ae01d46695311d458d43ea029
[3] https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=a1d95322f16a860f66badef748ef3d34416e922c

[Vlad Gridin (vladyslav-gridin)]

Fix pending for #1820044 will address this issue, however
current patchset does not handle tempest plugins.

[Vlad Gridin (vladyslav-gridin)]

Failure stable/rocky when TEMPEST_PLUGINS is set:

++./stack.sh:echo_summary:440 echo -e Installing Tempest Plugins
++extras.d/80-tempest.sh:source:23 install_tempest_plugins
++lib/tempest:install_tempest_plugins:677 pushd /opt/stack/tempest
/opt/stack/tempest /opt/stack/tempest
++lib/tempest:install_tempest_plugins:678 [[ /opt/stack/neutron-tempest-plugin != 0 ]]
++lib/tempest:install_tempest_plugins:680 cd /opt/stack/requirements
++lib/tempest:install_tempest_plugins:680 git show master:upper-constraints.txt
fatal: Invalid object name 'master'.
+lib/tempest:install_tempest_plugins:1 exit_trap

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/643333

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/643334

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/643341

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/643333
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=bcd8a50cc688ee39b4b998efe959e35c4c5b1408
Submitter: Zuul
Branch: master

commit bcd8a50cc688ee39b4b998efe959e35c4c5b1408
Author: Vlad Gridin <email address hidden>
Date: Thu Mar 14 14:40:55 2019 +0100

    Fix installing tempest plugins

    When running stack.sh locally on stable branches
    with tempest enabled and TEMPEST_PLUGINS set,
    devstack will try to fetch master branch of requirements
    and that fails if branch is not tracked.

    Change-Id: Ia1ae6869a8fede2af5cd7c875e0946b6a75eb518
    Closes-Bug: #1820051

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/643334
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=4138b301fbb0d6e532821714af4a0b63c4789365
Submitter: Zuul
Branch: stable/rocky

commit 4138b301fbb0d6e532821714af4a0b63c4789365
Author: Vlad Gridin <email address hidden>
Date: Thu Mar 14 14:40:55 2019 +0100

    Fix installing tempest plugins

    When running stack.sh locally on stable branches
    with tempest enabled and TEMPEST_PLUGINS set,
    devstack will try to fetch master branch of requirements
    and that fails if branch is not tracked.

    Change-Id: Ia1ae6869a8fede2af5cd7c875e0946b6a75eb518
    Closes-Bug: #1820051
    (cherry picked from commit bcd8a50cc688ee39b4b998efe959e35c4c5b1408)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/643341
Committed: https://git.openstack.org/cgit/openstack/devstack/commit/?id=e3100794d1615fc6b4216f54e2f7859a33d60b05
Submitter: Zuul
Branch: stable/queens

commit e3100794d1615fc6b4216f54e2f7859a33d60b05
Author: Vlad Gridin <email address hidden>
Date: Thu Mar 14 14:40:55 2019 +0100

    Fix installing tempest plugins

    When running stack.sh locally on stable branches
    with tempest enabled and TEMPEST_PLUGINS set,
    devstack will try to fetch master branch of requirements
    and that fails if branch is not tracked.

    Change-Id: Ia1ae6869a8fede2af5cd7c875e0946b6a75eb518
    Closes-Bug: #1820051
    (cherry picked from commit bcd8a50cc688ee39b4b998efe959e35c4c5b1408)