nova_cell1_conf is not configured for [neutron]

[Matt Riedemann]

In the default "superconductor" mode the cell conductor runs with the nova_cell1.conf config file, which isn't configured to talk to neutron:

http://logs.openstack.org/69/556669/4/check/tempest-full/c2bd2e9/controller/logs/etc/nova/nova_cell1_conf.txt.gz

Which means that on server build failure, nova-conductor in the cell can't deallocate networks for servers that fail to build:

http://logs.openstack.org/69/556669/4/check/tempest-full/c2bd2e9/controller/logs/screen-n-cond-cell1.txt.gz?level=TRACE#_Jun_18_18_10_47_255508

Jun 18 18:10:47.255508 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [None req-b55c7087-0680-4292-85c5-84cbc8409f2c tempest-ServerDiskConfigTestJSON-1411659828 tempest-ServerDiskConfigTestJSON-1411659828] [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] Failed to deallocate networks: Unauthorized: Unknown auth type: None
Jun 18 18:10:47.255844 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] Traceback (most recent call last):
Jun 18 18:10:47.256049 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] File "/opt/stack/nova/nova/conductor/manager.py", line 367, in _cleanup_allocated_networks
Jun 18 18:10:47.256218 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] context, instance, requested_networks=requested_networks)
Jun 18 18:10:47.256409 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] File "/opt/stack/nova/nova/network/neutronv2/api.py", line 1286, in deallocate_for_instance
Jun 18 18:10:47.256571 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] self._unbind_ports(context, ports_to_skip, neutron)
Jun 18 18:10:47.256740 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] File "/opt/stack/nova/nova/network/neutronv2/api.py", line 543, in _unbind_ports
Jun 18 18:10:47.256945 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] port_client = get_client(context, admin=True)
Jun 18 18:10:47.257123 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] File "/opt/stack/nova/nova/network/neutronv2/api.py", line 164, in get_client
Jun 18 18:10:47.257296 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] _ADMIN_AUTH = _load_auth_plugin(CONF)
Jun 18 18:10:47.257468 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] File "/opt/stack/nova/nova/network/neutronv2/api.py", line 87, in _load_auth_plugin
Jun 18 18:10:47.257646 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] raise neutron_client_exc.Unauthorized(message=err_msg)
Jun 18 18:10:47.257805 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e] Unauthorized: Unknown auth type: None
Jun 18 18:10:47.257958 ubuntu-xenial-inap-mtl01-0000202998 nova-conductor[15239]: ERROR nova.conductor.manager [instance: 946d6b98-0fbb-4243-bc01-f98df3b0d36e]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/576249

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/576249
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=e95f2a36645b58b172855213cb8311a3486bfcd9
Submitter: Zuul
Branch: master

commit e95f2a36645b58b172855213cb8311a3486bfcd9
Author: Matt Riedemann <email address hidden>
Date: Mon Jun 18 16:17:29 2018 -0400

    Configure [neutron] in nova_cell*.conf

    The nova-conductor service running in the cell
    needs to be configured to talk to neutron for
    things like deallocating networks during server
    build failure. This changes the configure_neutron_nova
    flows such that the top-level nova.conf is configured
    as before, but we also configure each nova_cell*.conf
    cell conductor config files to also be able to talk
    to neutron.

    Change-Id: Ic5e17298996b5fb085272425bb3b68583247aa34
    Closes-Bug: #1777505